Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cisco bug #32390

Merged
merged 8 commits into from Jan 31, 2024
Merged

Cisco bug #32390

merged 8 commits into from Jan 31, 2024

Conversation

merit-maita
Copy link
Contributor

@merit-maita merit-maita commented Jan 23, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-32635

Description

Fixed an issue in ciscofp-list-intrusion-rule command, where it failed when using the filter argument.

Must have

  • Tests
  • Documentation

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CiscoFirepower/Integrations/CiscoFirepower
   CiscoFirepower.py115670738%141, 165–166, 168, 176, 182, 184–185, 187–189, 192, 194, 215, 285–287, 299, 315–317, 331–334, 347–349, 364–366, 381–383, 398–400, 415–417, 434–436, 452–454, 466–467, 479–480, 495–497, 512–514, 531–533, 535–536, 554–556, 558–559, 577–579, 581–582, 594–595, 610–612, 625–627, 642, 649–650, 662–663, 676–677, 691–695, 709–713, 729–731, 780, 782, 784–785, 788, 791, 793, 795, 797, 799, 802, 807–808, 863, 865, 867, 869, 871, 874, 877, 879, 882, 884, 886, 889, 895–901, 903–907, 909, 911–914, 917–918, 921, 923–924, 1586, 1615, 1631, 1660–1662, 1693, 1720, 1738, 1970, 2039–2040, 2042, 2044, 2098–2104, 2115, 2118–2120, 2122, 2129, 2145–2153, 2156–2157, 2159, 2166, 2182–2190, 2193–2194, 2196, 2203, 2220–2222, 2224–2233, 2236–2237, 2239, 2246, 2263–2265, 2267–2276, 2279–2280, 2282, 2289, 2305–2313, 2316–2317, 2319, 2337–2345, 2348–2349, 2351, 2369–2376, 2378–2379, 2382–2383, 2385, 2403–2410, 2412–2413, 2416–2417, 2419, 2437–2442, 2445–2446, 2448, 2466–2471, 2474–2475, 2477, 2496–2507, 2510–2512, 2514, 2521, 2536–2547, 2550–2552, 2554, 2561, 2575–2584, 2588–2590, 2592, 2599, 2613–2619, 2621, 2623–2625, 2631, 2633–2634, 2640, 2647–2650, 2654–2656, 2658, 2665, 2679–2685, 2687, 2689–2691, 2697, 2699–2700, 2706, 2713–2716, 2720–2722, 2724, 2731, 2745–2749, 2752–2754, 2756, 2775–2786, 2789–2790, 2792, 2799, 2815–2820, 2823–2824, 2826, 2844–2847, 2849–2852, 2855–2856, 2858, 2876–2880, 2883–2884, 2886, 2904–2912, 2915–2916, 2918, 2925, 2941–2949, 2952–2953, 2955, 2962, 2978–2984, 2994, 2997–2998, 3000, 3007, 3023–3029, 3047, 3050–3052, 3054, 3061, 3077–3082, 3102–3103, 3106–3108, 3110, 3117, 3134–3144, 3146, 3150–3152, 3155, 3158, 3160, 3178–3194, 3196, 3213–3216, 3219, 3222, 3224, 3242–3260, 3262, 3281–3284, 3287, 3290, 3292, 3310–3316, 3319, 3322, 3324, 3343–3350, 3353–3355, 3357, 3364, 3380–3386, 3389–3391, 3393, 3411–3414, 3416–3417, 3421–3423, 3425–3426, 3429–3432, 3435–3437, 3439, 3457–3464, 3473–3474, 3477–3478, 3480, 3486–3487, 3496–3497, 3500–3501, 3503, 3510, 3526–3531, 3539–3540, 3543–3544, 3546, 3553, 3569–3572, 3574–3576, 3583, 3586–3588, 3590, 3609–3612, 3615–3616, 3619, 3621, 3628, 3739, 3742, 3746–3749, 3792, 3931, 4135, 4288, 4291, 4295–4298
TOTAL115670738% 

Tests Skipped Failures Errors Time
53 0 💤 0 ❌ 0 🔥 1.627s ⏱️

@merit-maita merit-maita merged commit 8577b20 into master Jan 31, 2024
19 checks passed
@merit-maita merit-maita deleted the cisco_bug branch January 31, 2024 07:42
yasta5 pushed a commit that referenced this pull request Feb 4, 2024
* fixed a bug in ciscofp-list-intrusion-rule command witht the filter arg

* added rn

* update the group command as well

* updated do

* edits after build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants