Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASM] xpsupport-2404 #32391

Merged
merged 10 commits into from Jan 24, 2024
Merged

[ASM] xpsupport-2404 #32391

merged 10 commits into from Jan 24, 2024

Conversation

johnnywilkes
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/XPSUPPORT-2404

Description

Added a check to determines if the Cortex Attack Surface Management integration instance is configured.

Must have

  • Tests
  • Documentation

@johnnywilkes johnnywilkes marked this pull request as draft January 23, 2024 18:33
@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jan 23, 2024
@johnnywilkes
Copy link
Contributor Author

@ShirleyDenkberg , please review

@BigEasyJ / @capanw , please review

@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_ASM-XPSUPPORT-2404 January 23, 2024 18:35
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @YuvHayun will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @johnnywilkes, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

@johnnywilkes johnnywilkes marked this pull request as ready for review January 23, 2024 23:06
@johnnywilkes
Copy link
Contributor Author

@YuvHayun / @melamedbn , this has been approved by Xpanse. Please merge when possible

ShirleyDenkberg
ShirleyDenkberg reviewed Jan 24, 2024
View reviewed changes
Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_Remediation_Guidance_README.md Outdated
@@ -10,15 +10,16 @@ This playbook does not use any sub-playbooks.

### Integrations

This playbook does not use any integrations.
* Cortex Attack Surface Management
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Cortex Attack Surface Management
Cortex Attack Surface Management

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in a1e7cfb

Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_Remediation_Guidance_README.md Outdated

### Scripts

Set
* Set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Set
Set

When there is only one item, we do not bullet it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in a1e7cfb

Packs/CortexAttackSurfaceManagement/ReleaseNotes/1_7_24.md Outdated

##### Cortex ASM - Remediation Guidance

Added a check to determine if the *Cortex Attack Surface Management* integration instance is configured.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Added a check to determine if the *Cortex Attack Surface Management* integration instance is configured.
Added a check to determine if the **Cortex Attack Surface Management** integration instance is configured.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in a1e7cfb

@ShirleyDenkberg ShirleyDenkberg self-assigned this Jan 24, 2024
@ShirleyDenkberg
Copy link
Contributor

@BigEasyJ @melamedbn @YuvHayun Doc review completed.

@BigEasyJ BigEasyJ mentioned this pull request Jan 24, 2024
Merged
5 tasks
@BigEasyJ
Copy link
Contributor

@YuvHayun @melamedbn please merge #32312 before if needed but the versions should not conflict now.

@YuvHayun
Copy link
Contributor

Hey @johnnywilkes @BigEasyJ, this pr is being handled by another reviewer.. please let me know when it's merged so I can merge this one.

@YuvHayun YuvHayun added the pending-contributor The PR is pending the response of its creator label Jan 24, 2024
@BigEasyJ
Copy link
Contributor

Ready to merge

@YuvHayun
Copy link
Contributor

Merging to internal pr, thx for your contribution.

@YuvHayun YuvHayun merged commit fc7b147 into demisto:contrib/PaloAltoNetworks_ASM-XPSUPPORT-2404 Jan 24, 2024
19 of 20 checks passed
@content-bot content-bot mentioned this pull request Jan 24, 2024
Merged
5 tasks
YuvHayun pushed a commit that referenced this pull request Jan 24, 2024
@content-bot @johnnywilkes @BigEasyJ
[ASM] xpsupport-2404 (#32391) (#32394)
614689d 
* change play

* RN

* Update Packs/CortexAttackSurfaceManagement/ReleaseNotes/1_7_25.md



* fixed RN typo

* fixed vers

* Update ReadMe and release notes with doc review suggestions

* Update release version

* Update release version

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Co-authored-by: bigeasyj <janny@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigEasyJ BigEasyJ BigEasyJ approved these changes

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@YuvHayun YuvHayun YuvHayun approved these changes

@melamedbn melamedbn Awaiting requested review from melamedbn

Assignees

@melamedbn melamedbn

@ShirleyDenkberg ShirleyDenkberg

@YuvHayun YuvHayun

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR pending-contributor The PR is pending the response of its creator Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
6 participants
@johnnywilkes @content-bot @ShirleyDenkberg @BigEasyJ @YuvHayun @melamedbn