Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Okta Event Collector] Add next pagination token logic #32393

Merged
merged 14 commits into from Feb 20, 2024

Conversation

samuelFain
Copy link
Contributor

@samuelFain samuelFain commented Jan 23, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

relates: XSUP-32551

Description

  • Identified and fixed an issue related to fetch logic (more info in the Jira ticket).
  • Implemented 'next' pagination token logic.

Must have

  • Tests
  • Documentation

@samuelFain samuelFain changed the title [Okta Event Collector] Add next logic to fetch [Okta Event Collector] Add next pagination token logic Jan 23, 2024
@samuelFain samuelFain self-assigned this Jan 23, 2024
@JasBeilin JasBeilin requested review from JasBeilin and removed request for JasBeilin February 8, 2024 10:45
Copy link

github-actions bot commented Feb 8, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Okta/Integrations/OktaEventCollector
   OktaEventCollector.py901583%23, 75–77, 88–91, 94–95, 97–100, 159
TOTAL901583% 

Tests Skipped Failures Errors Time
14 0 💤 0 ❌ 0 🔥 3.969s ⏱️

@samuelFain samuelFain marked this pull request as draft February 11, 2024 08:16
@samuelFain samuelFain marked this pull request as ready for review February 19, 2024 14:35
@samuelFain
Copy link
Contributor Author

@yuvalbenshalom Force merge is needed due to removal of "pragma: no cover" resulting in drop of UT coverage.
I raised the UT coverage to 83%.

@yuvalbenshalom yuvalbenshalom merged commit b6bd2fb into master Feb 20, 2024
17 of 19 checks passed
@yuvalbenshalom yuvalbenshalom deleted the bugfix/XSUP-32551/okta-event-collector branch February 20, 2024 08:34
maimorag pushed a commit that referenced this pull request Feb 22, 2024
* Update last fetch logic

* Implemented 'next' pagination token logic

* Handle resetting next_link token

* Update release notes

* FIxed failing UTs

* Remove pragma no cover

* Rename 3_2_10.md to 3_2_12.md

* add 3_2_10.md

* Add UTs

* Add UTs
maimorag pushed a commit that referenced this pull request Feb 28, 2024
* Update last fetch logic

* Implemented 'next' pagination token logic

* Handle resetting next_link token

* Update release notes

* FIxed failing UTs

* Remove pragma no cover

* Rename 3_2_10.md to 3_2_12.md

* add 3_2_10.md

* Add UTs

* Add UTs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants