Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core api multiple entries error #32412

Merged
merged 14 commits into from Jan 29, 2024
Merged

Conversation

anas-yousef
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-31868

Description

Added the option to run the command core-api-multipart subsequently in the playbook Process Email - Generic v2 by using the automation UploadFile with the option isArray: true.

Must have

  • Tests
  • Documentation

@anas-yousef anas-yousef changed the title Ay core api multiple entries error Core api multiple entries error Jan 24, 2024
@anas-yousef anas-yousef self-assigned this Jan 24, 2024
@anas-yousef anas-yousef marked this pull request as ready for review January 25, 2024 12:45
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please see my comments.

Copy link
Contributor

@idovandijk idovandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look OK, but do we still need to check if the Core API integration is enabled if we use this script?
Also was this tested successfully on XSOAR 8? You can forward an EML file to a phishing inbox, it should trigger that flow in the playbook

@anas-yousef
Copy link
Contributor Author

anas-yousef commented Jan 28, 2024

@idovandijk
I believe so, since the script UploadFile relies on the command core-api-multipart.

@anas-yousef
Copy link
Contributor Author

Concerning testing this on XSOAR 8, I checked the script UploadFile by creating a new playbook that uses it, and saw that it is able to run on multiple entry IDs, and upload the attachments to the relevant incident.
@idovandijk I sent you in private so we can test the whole flow of the playbook in XSOAR 8

@idovandijk
Copy link
Contributor

Concerning testing this on XSOAR 8, I checked the script UploadFile by creating a new playbook that uses it, and saw that it is able to run on multiple entry IDs, and upload the attachments to the relevant incident. @idovandijk I sent you in private so we can test the whole flow of the playbook in XSOAR 8

Need to verify that the newly uploaded files show up in the layout

@anas-yousef anas-yousef merged commit 9b5a4c6 into master Jan 29, 2024
19 checks passed
@anas-yousef anas-yousef deleted the ay-core-api-multiple-entries-error branch January 29, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants