Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace Contribution] Community Common Scripts - Content Pack Update #32564

Conversation

xsoar-bot
Copy link
Contributor

Warning
The changes in the contributed files were not made on the most updated pack versions

Item Name Contribution Pack Version Latest Pack Version
RetrievePlaybookDependencies 1.1.5 1.1.6

For the Reviewer:

  1. Compare the code of this PR with the latest version of the pack. Make sure you understand the changes the contributor intended to contribute, and solve the conflicts accordingly.
  2. In case improvements are needed, instruct the contributor to edit the code through the GitHub Codespaces and Not through the XSOAR UI.

For the Contributor:
@NicCas
In case you are requested by your reviewer to improve the code or to make changes, submit them through the GitHub Codespaces and Not through the XSOAR UI.

To use the GitHub Codespaces, do the following:

  1. Click the 'Code' button in the right upper corner of this PR.
  2. Click 'Create codespace on Transformers'.
  3. Click 'Authorize and continue'.
  4. Wait until your Codespace environment is generated. When it is, you can edit your code.
  5. Commit and push your changes to the head branch of the PR.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@NicCas

Notes

Demo available on request, I'm happy to demo live or send a recording over slack!

All the new arguments are optional and backwards compatible.

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Community Support Level Indicates that the contribution is for Community supported pack labels Jan 31, 2024
@content-bot content-bot changed the base branch from master to contrib/xsoar-contrib_NicCas-contrib-CommunityCommonScripts January 31, 2024 22:43
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @yucohen will very shortly look over your proposed changes.
For your convenience, here is a link to the contributions SLAs document.

@yucohen
Copy link
Contributor

yucohen commented Feb 4, 2024

Hi @NicCas
Thanks for your contribution! Great work!
I'll fix the build and merge your PR soon

…ipts' into NicCas-contrib-CommunityCommonScripts
@yucohen yucohen merged commit 109302a into demisto:contrib/xsoar-contrib_NicCas-contrib-CommunityCommonScripts Feb 4, 2024
22 of 23 checks passed
yucohen added a commit that referenced this pull request Feb 5, 2024
…date (#32564) (#32699)

* "contribution update to pack "Community Common Scripts""

* Removed commented out alt regex string

* fixed build

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com>
Co-authored-by: yucohen <yucohen@paloaltonetworks.com>
Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Support Level Indicates that the contribution is for Community supported pack Contribution Thank you! Contributions are always welcome! docs-approved External PR
Projects
None yet
4 participants