[TopMaliciousRatioIndicators] Fix long calculation time #32581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove pythonic filtering of investigation based on investigationIDs amount.
Coverage Report
|
||||||||||||||||||||||||||||||
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
JasBeilin
requested changes
Feb 4, 2024
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
JasBeilin
reviewed
Feb 4, 2024
…ors-long-calc-time
…ors-long-calc-time
samuelFain
deleted the
bugfix/CRTX-86113/TopMaliciousRatioIndicators-long-calc-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove pythonic filtering of investigation based on investigationIDs amount.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: CRTX-86113
Description
findIndicatorscommand in theTopMaliciousRatioIndicatorsscript has been updated - theinvestigationsCountquery argument has been added to provide more accurate results.maxNumberOfIndicatorshas been lowered from 10,000 to 1,000 since it's no longer necessary to iterate over a large number of results to find relevant indicators - all returned indicators from the query are now relevant.Must have