Prisma Cloud Minimal Response #32606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
||||||||||||||||||||||||||||||
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
anara123
reviewed
Feb 2, 2024
| @@ -200,17 +200,33 @@ def remediation_command_list_request(self, time_range: Dict[str, Any], alert_ids | |||
| def alert_remediate_request(self, alert_id: str): | |||
| self._http_request('PATCH', f'alert/remediation/{alert_id}', resp_type='response') | |||
|
|
|||
| def remove_additional_resource_fields(self, input_dict, keys): | |||
There was a problem hiding this comment.
I would avoid recursion. instead lets just delete the fields one by one.
There was a problem hiding this comment.
These fields could appear several times, and I need to modify the object as I go.
anara123
reviewed
Feb 2, 2024
| @@ -1520,3 +1522,22 @@ def test_update_remote_system_command(mocker, prisma_cloud_v2_mirroring_client, | |||
|
|
|||
| assert mock_update_remote_alert.call_count == expected_call_count | |||
| assert result == 'P-1111111' | |||
|
|
|||
There was a problem hiding this comment.
add more broad test where passing, include_resource_json=false will return response without the two additional fields.
There was a problem hiding this comment.
The current test tests both remove and non-removed fields.
Testing the calling method means using mocking, which will not test my new code.
BEAdi
requested changes
Feb 4, 2024
BEAdi
reviewed
Feb 4, 2024
Packs/PrismaCloud/Integrations/PrismaCloudV2/PrismaCloudV2_test.py
Outdated
Show resolved
Hide resolved
BEAdi
approved these changes
Feb 4, 2024
Co-authored-by: Adi Bamberger Edri <72088126+BEAdi@users.noreply.github.com>
…t.py Co-authored-by: Adi Bamberger Edri <72088126+BEAdi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support minimizing Prisma Cloud output size in prisma-cloud-config-search
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9646