Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cortex REST API] New Script GetIncidentTasks #32607

Merged
merged 5 commits into from Feb 4, 2024

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@rundssoar

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • Ready

Description

This is a python port of the "GetIncidentTasksByState" Automation with the addition, that it is now possible to get Incident tasks by tag, names, states or any combination of those

Must have

  • Tests
  • Documentation

* Add GetIncidentTasks Automation

* update release notes

* Address review comments

* update release notes

* add unit tests for get_task_command
also adjust readable output and remove no longer necessary function

* deprecate GetIncidentTasksByState

* Revert changes to tests/conf.json

* address spelling comments

* revert further changes in tests/conf.json

* update release notes

* Update Packs/DemistoRESTAPI/ReleaseNotes/1_3_47.md

* Add removeNull to Warroom output

* name arguments in tableToMarkdown explicitly

* fix output test after removeNull setting

* Add LoopError and WillNotBeExecuted as possible states

* Update readme

* Update Packs/DemistoRESTAPI/ReleaseNotes/1_3_48.md

* Update Packs/DemistoRESTAPI/ReleaseNotes/1_3_48.md

* added RN

* Avoid duplicate states, if none are provided

* Update Docker container

---------

Co-authored-by: Shmuel Kroizer <69422117+shmuel44@users.noreply.github.com>
Co-authored-by: Shmuel Kroizer <skroizer@paloaltonetworks.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. pending-demo Demo pending Contribution Form Filled Whether contribution form filled or not. Community pending-contributor The PR is pending the response of its creator Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR labels Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/DemistoRESTAPI/Scripts/GetIncidentTasks
   GetIncidentTasks.py53688%98, 102, 137–140
TOTAL53688% 

Tests Skipped Failures Errors Time
11 0 💤 0 ❌ 0 🔥 1.756s ⏱️

@shmuel44 shmuel44 merged commit db9bbc2 into master Feb 4, 2024
16 checks passed
@shmuel44 shmuel44 deleted the contrib/rundssoar_get-task-by branch February 4, 2024 06:16
yasta5 pushed a commit that referenced this pull request Feb 4, 2024
* [Cortex REST API] New Script GetIncidentTasks (#32384)

* Add GetIncidentTasks Automation

* update release notes

* Address review comments

* update release notes

* add unit tests for get_task_command
also adjust readable output and remove no longer necessary function

* deprecate GetIncidentTasksByState

* Revert changes to tests/conf.json

* address spelling comments

* revert further changes in tests/conf.json

* update release notes

* Update Packs/DemistoRESTAPI/ReleaseNotes/1_3_47.md

* Add removeNull to Warroom output

* name arguments in tableToMarkdown explicitly

* fix output test after removeNull setting

* Add LoopError and WillNotBeExecuted as possible states

* Update readme

* Update Packs/DemistoRESTAPI/ReleaseNotes/1_3_48.md

* Update Packs/DemistoRESTAPI/ReleaseNotes/1_3_48.md

* added RN

* Avoid duplicate states, if none are provided

* Update Docker container

---------

Co-authored-by: Shmuel Kroizer <69422117+shmuel44@users.noreply.github.com>
Co-authored-by: Shmuel Kroizer <skroizer@paloaltonetworks.com>

* black format on the test file

* Update README file

---------

Co-authored-by: rundssoar <139948408+rundssoar@users.noreply.github.com>
Co-authored-by: Shmuel Kroizer <69422117+shmuel44@users.noreply.github.com>
Co-authored-by: Shmuel Kroizer <skroizer@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR pending-contributor The PR is pending the response of its creator pending-demo Demo pending ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
3 participants