add ews-resolve-names command #32613
Conversation
| if isinstance(contact, Contact) and contact.physical_addresses: | ||
| contact_dict['physical_addresses'] = list(map(parse_physical_address, contact.physical_addresses)) | ||
| if isinstance(contact, Contact) and contact.phone_numbers: | ||
| contact_dict['phone_numbers'] = [elt for elt in map(parse_phone_number, contact.phone_numbers) if elt] |
There was a problem hiding this comment.
Why have we added the if statement?
There was a problem hiding this comment.
if no phone numbers are defined exchangelib was returning
{ 'label' : 'bussiness', 'number' : None } so the context had a bunch of info like
numbers:
label: bussiness
label: personal
without any real numbers, so i switched the logic here that if a number doesnt exist to not return anything
Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
|
@JudahSchwartz doc review? |
|
@ShahafBenYakir @amshamah419 Doc review completed. |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
|
adding CommonReports as a dependency for DeveloperTools as per @dantavori's advice, |
|
forcing because theres an issue that core packs arent installed in the ng build. These will be addressed in https://jira-dc.paloaltonetworks.com/browse/CIAC-9721 |
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9330
Description
Added the resolve-names command
Must have