Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opsgenie-create-alert Tags arg to list #32616

Merged
merged 7 commits into from Feb 4, 2024

Conversation

jbabazadeh
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-33031

Description

base on Opsgenie documentation the tags field should be list
https://docs.opsgenie.com/docs/alert-api#create-alert

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Feb 1, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/OpsGenie/Integrations/OpsGenieV3
   OpsGenieV3.py53915171%46, 50, 71, 75, 82, 86, 91, 96–97, 102, 106–109, 112, 117, 123, 128, 139, 145–149, 155, 160, 165–166, 171, 176–177, 179, 184–185, 191–193, 195, 200–201, 208–210, 216, 221–223, 230–232, 238, 244, 249, 254, 281–282, 287, 291–294, 297, 303, 311, 317–318, 324–325, 332, 338, 343, 348, 383, 399–402, 407, 413, 418–422, 424, 434, 436–439, 444, 451, 455–456, 471–477, 489, 534, 548, 562, 571, 584, 598, 618, 630, 644, 658, 672, 686, 741–742, 770, 784, 828, 842, 856, 870, 884, 901–902, 960–962, 1009, 1015, 1081–1084, 1086–1088, 1097, 1129–1130, 1132–1134, 1137–1138, 1140–1141, 1143, 1146–1148
TOTAL53915171% 

Tests Skipped Failures Errors Time
62 0 💤 0 ❌ 0 🔥 1.947s ⏱️

Copy link
Contributor

@dorschw dorschw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! please add a simple unit test.

Packs/OpsGenie/ReleaseNotes/2_0_23.md Outdated Show resolved Hide resolved
@jbabazadeh jbabazadeh merged commit a89e0c8 into master Feb 4, 2024
19 checks passed
@jbabazadeh jbabazadeh deleted the opsgenie-create-alert-tag-fix branch February 4, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants