Enhancement | InfoBlox - add list host and network info, modify get IP cmds #32619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved request params into client
parsed extattrs into dict for context
added command examples fixed context key in net info command added types to context outputs for list host and net cmds
kgal-pan
changed the title
There was a problem hiding this comment.
Nice work!
- After you go over my comments let's go over them before you fix (at least on the ones which are "questions")
- Request review from doc team (Jira ticket: Documentation tab > Documentation required: yes, it will create a ticket for the dic team)
- Please set up a demo with TPM me and Anar
...oblox/Integrations/Infoblox/test_files/TestHostRecordsOperations/get_record_by_hostname.json
Outdated
Show resolved
Hide resolved
add breaking changes in md
pr review: empty dict evaluates to false, no need to cast to bool
client params instantiated with _return_as_object=1 add capture stderr ignore pr review: use any() instead of sum() == 0
kgal-pan
commented
Feb 7, 2024
kgal-pan
commented
Feb 7, 2024
kgal-pan
commented
Feb 7, 2024
|
pre-commit and validation failing because of breaking changes mentioned. |
ShahafBenYakir
approved these changes
Mar 3, 2024
|
@ShahafBenYakir Doc review completed |
MosheEichler
pushed a commit
that referenced
this pull request
Mar 4, 2024
…P cmds (#32619) * added host records * handle no comma,equal sign in extattrs * wip: added network,to/from_ip args to get_ip_cmd * added validation for invalid input args to get-ip moved request params into client * added max_results to list host cmd * added network info cmd * modified get-ip command to return a list added rns * format/validation fixes * fixed context output for host records cmd * fixed output table for net info cmd * added additional return fields to list host args parsed extattrs into dict for context * updated integration docs added command examples fixed context key in net info command added types to context outputs for list host and net cmds * fixed netview context key in net uts * changed context output types for get-ip added bc mentions for get-ip context output keys * fixed hardcoded default values in args description add breaking changes in md * mv test_files test_data * mv test_files test_data * converted integration readme from html to markdown pr review: empty dict evaluates to false, no need to cast to bool * strip whitespace from get-ip context path in readme * add unique to ipv4address status client params instantiated with _return_as_object=1 add capture stderr ignore pr review: use any() instead of sum() == 0 * pr review: rm endpoint suffixes from client pr review: rm max_results from list host commandres title pr review: add default val for max results to bc * pr review: rm ip,netmask input validation rm max_results and added mode/val in title for get-ip-cmd * mv request params into client methods * rm transform_return_fields * simplified raw to context mapping * raise exception when extattrs input is invalid * updated docker image rm max results from hr for net info cmd added todos for checking unexpected invalid extattrs rm exception var * fixed issue with additional return fields * fix flake8 errs * rm todos fixed issue with too many args supplied to ip command * revert changes to too many args handle in ip cmd * fixed titles for get-ip, get host info, get network info * added rn comment about get-ip mod outputs * fix rn comment about get-ip mod outputs * fix cmd outputs assertions in uts * added args to get-ip in integration doc * update docker image * fix docs * revert poetry * fix docs
MosheEichler
added a commit
that referenced
this pull request
Mar 21, 2024
…ation (#33155) * fix default key * rn * docker * docs review * [ConvertFile] Bump Docker version (#33141) * Update Docker version * Bump version * ruff * Bump pack from version CommonScripts to 1.14.4. * Bump Docker version * Bump pack from version CommonScripts to 1.14.5. * Bump pack from version CommonScripts to 1.14.6. --------- Co-authored-by: Content Bot <bot@demisto.com> * Added Compatibility with new Allowed Indicator Module in CTIX 3.6 (#33062) (#33159) I also ran all of the pre-commit hooks and resolved all of those issues. Co-authored-by: Corey Bodendein <corey.bodendein@cyware.com> * Fix/[XSUP-33795]/Logo does not shown in data collection form (#33154) * change default to true * add s flag * add UT * RN * pre-commit * mocker * fix default key * revert * EWS v2: added arg to the command (#33096) * added arg to the command * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fix validate --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Rasterize Latest Poppler (#32997) * Teams generate url command bug (#33164) * fixed a bug in generate url command * added rn * added rn * edit * added bc rn * edits * fixed unit test * updated do * Enhancement | InfoBlox - add list host and network info, modify get IP cmds (#32619) * added host records * handle no comma,equal sign in extattrs * wip: added network,to/from_ip args to get_ip_cmd * added validation for invalid input args to get-ip moved request params into client * added max_results to list host cmd * added network info cmd * modified get-ip command to return a list added rns * format/validation fixes * fixed context output for host records cmd * fixed output table for net info cmd * added additional return fields to list host args parsed extattrs into dict for context * updated integration docs added command examples fixed context key in net info command added types to context outputs for list host and net cmds * fixed netview context key in net uts * changed context output types for get-ip added bc mentions for get-ip context output keys * fixed hardcoded default values in args description add breaking changes in md * mv test_files test_data * mv test_files test_data * converted integration readme from html to markdown pr review: empty dict evaluates to false, no need to cast to bool * strip whitespace from get-ip context path in readme * add unique to ipv4address status client params instantiated with _return_as_object=1 add capture stderr ignore pr review: use any() instead of sum() == 0 * pr review: rm endpoint suffixes from client pr review: rm max_results from list host commandres title pr review: add default val for max results to bc * pr review: rm ip,netmask input validation rm max_results and added mode/val in title for get-ip-cmd * mv request params into client methods * rm transform_return_fields * simplified raw to context mapping * raise exception when extattrs input is invalid * updated docker image rm max results from hr for net info cmd added todos for checking unexpected invalid extattrs rm exception var * fixed issue with additional return fields * fix flake8 errs * rm todos fixed issue with too many args supplied to ip command * revert changes to too many args handle in ip cmd * fixed titles for get-ip, get host info, get network info * added rn comment about get-ip mod outputs * fix rn comment about get-ip mod outputs * fix cmd outputs assertions in uts * added args to get-ip in integration doc * update docker image * fix docs * revert poetry * fix docs * Update README.md (#33211) edited description of cron argument, per Dudu B. * download and move images to content repo (#33204) * download and move images to content repo * commit test * revert changes for gitlab_slack_notifier * Update Docker Image To demisto/chromium (#33175) * Updated Metadata Of Pack rasterize * Added release notes to pack rasterize * Packs/rasterize/Integrations/rasterize/rasterize.yml Docker image update * Updated Metadata Of Pack ExpanseV2 * Added release notes to pack ExpanseV2 * Packs/ExpanseV2/Scripts/ExpanseGenerateIssueMapWidgetScript/ExpanseGenerateIssueMapWidgetScript.yml Docker image update * Bump pack from version ExpanseV2 to 1.10.51. * Bump pack from version rasterize to 2.0.2. --------- Co-authored-by: Content Bot <bot@demisto.com> * docker * do not write files when running test-module * RN * ignore error 125 * docker * Fix RN * revert * ignore investigation attachments in test module command --------- Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> Co-authored-by: Content Bot <bot@demisto.com> Co-authored-by: content-bot <55035720+content-bot@users.noreply.github.com> Co-authored-by: Corey Bodendein <corey.bodendein@cyware.com> Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: tkatzir <tkatzir@paloaltonetworks.com> Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com> Co-authored-by: Kobbi Gal <85439776+kgal-pan@users.noreply.github.com> Co-authored-by: Tamar Schanfeld <76044549+tschanfeld@users.noreply.github.com> Co-authored-by: israelpoli <72099621+israelpoli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-5843
Description
This PR introduces the following changes:
infoblox-list-host-info.infoblox-list-network-info.infoblox-get-ipcommand output (breaking changes) and arguments.Must have