[CommonScripts] Fix comparison key in ProvidesCommand script #32676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(ProvidesCommand): Fix dict key when comparing command with enabled instances * fix(ProvidesCommand): modify release note to pass pipeline * fix(ProvidesCommand): add release note version * add name in the list * fix after review --------- Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
content-bot
added
Contribution
Coverage Report
|
||||||||||||||||||||||||||||||
YuvHayun
approved these changes
Feb 2, 2024
yasta5
pushed a commit
that referenced
this pull request
Feb 4, 2024
…#32676) * fix(ProvidesCommand): Fix dict key when comparing command with enabled instances * fix(ProvidesCommand): modify release note to pass pipeline * fix(ProvidesCommand): add release note version * add name in the list * fix after review --------- Co-authored-by: pl-brault <143391737+pl-brault@users.noreply.github.com> Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@pl-brault
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
When comparing the instance name between the enabled instances and the integration commands , the check was made on the "display" key which wasn't the same as the "brand" key retrieved before in
integration_search_res.Example:
Here is the display:
Here is the brand:
Must have