Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"xdr-iocs-sync" command enhanced to add a link to the indicator page within XSOAR. #32681

Merged
merged 57 commits into from Mar 6, 2024

Conversation

maimorag
Copy link
Contributor

@maimorag maimorag commented Feb 3, 2024

Status

  • In Progress

Related Issues

fixes: link to the issue

Description

The "xdr-iocs-sync" command enhanced to add a link to the indicator page within XSOAR.

@maimorag maimorag changed the title test "xdr-iocs-sync" command enhanced to add a link to the indicator page within XSOAR. Feb 3, 2024
Copy link

github-actions bot commented Feb 3, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CortexXDR/Integrations/XDR_iocs
   XDR_iocs.py4387483%94, 105, 149, 208–209, 218–219, 276, 315, 393–396, 398, 419–427, 429–433, 435–438, 445–446, 461, 463–465, 497, 511, 516, 531, 562, 576, 580–585, 589–591, 593, 596–602, 604–605, 609–610, 612, 614, 657, 676–679, 707, 713
TOTAL4387483% 

Tests Skipped Failures Errors Time
128 2 💤 1 ❌ 0 🔥 3.585s ⏱️

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CortexXDR pack version was bumped to 6.1.12.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CortexXDR pack version was bumped to 6.1.13.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@maimorag maimorag marked this pull request as ready for review February 14, 2024 08:00
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CortexXDR pack version was bumped to 6.1.17.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CortexXDR pack version was bumped to 6.1.18.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

Copy link
Contributor

@eyalpalo eyalpalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add relevant documentation to the integration as well

Packs/CortexXDR/Integrations/XDR_iocs/XDR_iocs.py Outdated Show resolved Hide resolved
Packs/CortexXDR/Integrations/XDR_iocs/XDR_iocs.py Outdated Show resolved Hide resolved
Packs/CortexXDR/Integrations/XDR_iocs/XDR_iocs_test.py Outdated Show resolved Hide resolved
Packs/CortexXDR/Integrations/XDR_iocs/XDR_iocs_test.py Outdated Show resolved Hide resolved
Packs/CortexXDR/ReleaseNotes/6_1_18.md Outdated Show resolved Hide resolved
maimorag and others added 4 commits February 19, 2024 13:54
Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com>
Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com>
Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com>
omerKarkKatz and others added 7 commits March 4, 2024 13:36
* added the using to uploadfile automation

* fix test

* release notes pre commit

* ruff changes
* bump candidate

* bump 8.6
* [ServiceNow v2] Fixed issue in Fetches incidents

* Fix the RN

* Fix the RN

* Fix the fetch in case of use_display_value

* Add DocStrings

* Update Packs/ServiceNow/Integrations/ServiceNowv2/ServiceNowv2.py

Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>

* Update the docker image

---------

Co-authored-by: Binat Ziser <89336697+bziser@users.noreply.github.com>
* Update Docker version

* Bump version

* ruff

* Bump pack from version CommonScripts to 1.14.4.

* Bump Docker version

* Bump pack from version CommonScripts to 1.14.5.

* Bump pack from version CommonScripts to 1.14.6.

---------

Co-authored-by: Content Bot <bot@demisto.com>
…3062) (#33159)

I also ran all of the pre-commit hooks and resolved all of those issues.

Co-authored-by: Corey Bodendein <corey.bodendein@cyware.com>
* change default to true

* add s flag

* add UT

* RN

* pre-commit

* mocker

* fix default key

* revert
* added arg to the command

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* fix validate

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Copy link

github-actions bot commented Mar 4, 2024

Your contributed Ataya pack has been modified on files:

Packs/Ataya/ReleaseNotes/1_0_5.md
Packs/Ataya/pack_metadata.json
Packs/Ataya/Integrations/Ataya/Ataya.yml
Please review the changes here

Copy link

github-actions bot commented Mar 4, 2024

Your contributed Binalyze pack has been modified on files:

Packs/Binalyze/pack_metadata.json
Packs/Binalyze/Integrations/BinalyzeAIR/BinalyzeAIR.yml
Packs/Binalyze/ReleaseNotes/1_1_6.md
Please review the changes here

Copy link

github-actions bot commented Mar 4, 2024

Your contributed AbnormalSecurity pack has been modified on files:

Packs/AbnormalSecurity/Integrations/AbnormalSecurity/AbnormalSecurity.yml
Packs/AbnormalSecurity/ReleaseNotes/2_2_6.md
Packs/AbnormalSecurity/pack_metadata.json
Please review the changes here

Packs/CortexXDR/Integrations/XDR_iocs/XDR_iocs.py Outdated Show resolved Hide resolved
Packs/CortexXDR/Integrations/XDR_iocs/XDR_iocs.py Outdated Show resolved Hide resolved
Packs/CortexXDR/Integrations/XDR_iocs/XDR_iocs.py Outdated Show resolved Hide resolved
Packs/CortexXDR/Integrations/XDR_iocs/XDR_iocs.yml Outdated Show resolved Hide resolved
Packs/CortexXDR/Integrations/XDR_iocs/XDR_iocs_test.py Outdated Show resolved Hide resolved
@maimorag maimorag merged commit 8ee9d2c into master Mar 6, 2024
21 checks passed
@maimorag maimorag deleted the 9153-XDR-IOC-add-link branch March 6, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants