Prisma Cloud Minimal Response 2 #32714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Adi Bamberger Edri <72088126+BEAdi@users.noreply.github.com>
Coverage Report
|
||||||||||||||||||||||||||||||
anara123
reviewed
Feb 5, 2024
| items = demisto.get(input_dict, 'data.items') | ||
| if items: | ||
| for current_item in list(items): | ||
| data = current_item['data'] |
| metadata = data['metadata'] | ||
| metadata_items = metadata['items'] | ||
| if metadata_items: | ||
| for current_metadata_item in list(metadata_items): |
There was a problem hiding this comment.
why do you convert to list? list(metadata_items)
There was a problem hiding this comment.
Because I don't want to change the list I'm iterating on.
anara123
approved these changes
Feb 5, 2024
anara123
reviewed
Feb 5, 2024
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "breakingChanges": true, | |||
| "breakingChangesNotes": "The output now lacks the folowing 2 values by default: ***data.items.data.disks.shieldedInstanceInitialState***, ***data.items.data.metadata.items.configure-sh***. Use the argument ****include_additional_resource_fields=true**** to include their values in the output." | |||
There was a problem hiding this comment.
Explain here, if a user needs one those values, what they should do
There was a problem hiding this comment.
It's there:
Use the argument include_additional_resource_fields=true to include their values in the output.
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support minimizing Prisma Cloud output size in prisma-cloud-config-search
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9646