Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix to URL regex and formatter #32719

Merged
merged 23 commits into from Feb 12, 2024
Merged

Small fix to URL regex and formatter #32719

merged 23 commits into from Feb 12, 2024

Conversation

Ni-Knight
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-32598

Description

Allows the url regex to capture quoted schemes and unquotes URLs as many times as needed.

Copy link

github-actions bot commented Feb 6, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CommonScripts/Scripts/FormatURL
   FormatURL.py3892094%107, 128, 131, 134, 157, 171, 218, 247, 281, 449, 483, 486, 637, 737, 755–756, 764–765, 780–781
TOTAL3892094% 

Tests Skipped Failures Errors Time
152 0 💤 0 ❌ 0 🔥 1.750s ⏱️

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.13.36.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@Ni-Knight Ni-Knight requested review from DeanArbel and altmannyarden and removed request for michalgold and idovandijk February 7, 2024 12:03
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.13.37.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.13.38.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@Ni-Knight Ni-Knight merged commit a6fcff2 into master Feb 12, 2024
18 of 19 checks passed
@Ni-Knight Ni-Knight deleted the dra-url-regex branch February 12, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants