Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeedElasticSearch] Fix ids in last run #32778

Merged
merged 18 commits into from Feb 20, 2024
Merged

[FeedElasticSearch] Fix ids in last run #32778

merged 18 commits into from Feb 20, 2024

Conversation

ilaner
Copy link
Contributor

@ilaner ilaner commented Feb 7, 2024

In the previous version, we intorduced fetching indicators from elastic search in batches. We save in the last run the last indicator timestamp and the ids which were fetched in the previous version, to handle duplicates.

There is an issue where the ids list is based on the datetime object and not the timestamp, which causes this list to be inaccurate.

related: https://jira-dc.paloaltonetworks.com/browse/XSUP-33218

Copy link

github-actions bot commented Feb 7, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/FeedElasticsearch/Integrations/FeedElasticsearch
   FeedElasticsearch.py30317741%36–38, 77, 81, 84–86, 88–89, 99–102, 120–128, 130–146, 148–153, 155–156, 158, 163, 165–166, 168, 173–177, 180–186, 191–195, 200–209, 219–220, 230, 238–244, 246–248, 250–251, 253–255, 257–266, 268–270, 275–276, 278–280, 282–285, 291–298, 301, 304–305, 319–320, 323–329, 331–334, 337, 399–418, 420–423, 425–426, 428–433
TOTAL30317741% 

Tests Skipped Failures Errors Time
12 0 💤 0 ❌ 0 🔥 2.302s ⏱️

Copy link
Contributor

@yuvalbenshalom yuvalbenshalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • FeedElasticsearch pack version was bumped to 1.1.5.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@ilaner ilaner merged commit 2d351ce into master Feb 20, 2024
20 checks passed
@ilaner ilaner deleted the feedelastic-move-to-str branch February 20, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants