New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FeedElasticSearch] Fix ids in last run #32778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
yuvalbenshalom
requested changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment
Packs/FeedElasticsearch/Integrations/FeedElasticsearch/FeedElasticsearch.py
Outdated
Show resolved
Hide resolved
Packs/FeedElasticsearch/Integrations/FeedElasticsearch/FeedElasticsearch.py
Outdated
Show resolved
Hide resolved
…sticsearch.py Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>
…into feedelastic-move-to-str
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
yuvalbenshalom
approved these changes
Feb 20, 2024
maimorag
pushed a commit
that referenced
this pull request
Feb 22, 2024
maimorag
pushed a commit
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version, we intorduced fetching indicators from elastic search in batches. We save in the last run the last indicator timestamp and the ids which were fetched in the previous version, to handle duplicates.
There is an issue where the ids list is based on the
datetime
object and not the timestamp, which causes this list to be inaccurate.related: https://jira-dc.paloaltonetworks.com/browse/XSUP-33218