[CIAC-6775] [PAN-OS] Add audit-comment argument

[yaakovpraisler]

Status

• In Progress
• Ready
• In Hold - (Reason for hold)

Related Issues

fixes: CIAC-6775

Description

1. Added a new argument audit-comment to the following commands:
   • pan-os-create-rule
   • pan-os-create-pbf-rule
   • pan-os-create-nat-rule
   • pan-os-edit-pbf-rule
   • pan-os-edit-nat-rule
2. Added the new command pan-os-get-audit-comment.
3. Added ip-wildcard in pan-os-list-addresses result.

Must have

• Tests
• Documentation

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
Packs/PAN-OS/Integrations/Panorama
Panorama.py	5819	2181	62%	241, 248, 271, 278, 280, 308, 313, 315, 330, 336, 339, 347, 351–352, 356, 358, 361–362, 364, 368–369, 376, 384, 390, 393–394, 398, 415, 449–451, 470, 505, 520, 567, 573, 591, 596, 624–625, 633–634, 691–692, 695, 723–724, 759, 769, 775, 781–782, 784–786, 788, 790–791, 794–795, 797–800, 802, 828–829, 852, 857, 862, 869, 876, 881, 888, 895, 901, 914–915, 919, 924–925, 927–928, 930, 948–950, 958, 965, 971–973, 975, 977–978, 980, 987–989, 998, 1000–1001, 1003–1004, 1006, 1013, 1120–1121, 1149, 1164, 1166–1167, 1169–1172, 1175–1176, 1178–1180, 1183–1185, 1187–1188, 1190, 1213, 1249, 1282, 1310, 1352, 1355, 1381, 1404, 1433, 1444, 1462, 1471, 1478, 1485–1486, 1489, 1501, 1514–1516, 1518, 1520, 1536, 1542, 1544, 1548, 1550, 1556, 1565, 1572–1573, 1575, 1581, 1588–1589, 1591, 1608, 1616, 1619, 1624, 1647, 1649, 1661, 1663, 1680, 1692, 1739, 1741–1753, 1755, 1804, 1811, 1817, 1824, 1826–1829, 1831, 1847–1851, 1855–1859, 1862, 1864, 1866–1867, 1869, 1871, 1873, 1878, 1885–1886, 1888, 1894, 1901–1902, 1904, 1924, 1926, 1930, 1961, 1963, 1965, 1982, 1992, 1998, 2003, 2013, 2019, 2026–2039, 2041–2042, 2044, 2046, 2050–2059, 2061, 2075, 2083, 2089, 2097–2100, 2102, 2126–2129, 2133, 2141, 2149–2150, 2169–2171, 2176, 2179–2181, 2186, 2201–2205, 2210, 2228–2229, 2231–2239, 2241–2246, 2248–2249, 2251–2254, 2256, 2258, 2263, 2270–2271, 2273, 2279, 2286–2287, 2289, 2308, 2312, 2318–2319, 2321, 2327, 2334, 2340, 2346, 2354–2355, 2357, 2374, 2387, 2393, 2400–2405, 2407, 2409, 2414–2421, 2423, 2437, 2444, 2450, 2458–2461, 2463, 2479–2480, 2482–2484, 2488–2490, 2493, 2495, 2497, 2502, 2509–2510, 2512, 2518, 2525–2526, 2528, 2547, 2551, 2558, 2564, 2570, 2578–2579, 2581, 2595, 2604, 2610, 2617–2619, 2621, 2623, 2627–2630, 2632, 2646, 2653, 2659, 2667–2670, 2672, 2695–2699, 2730, 2733, 2737–2740, 2742, 2744–2745, 2753, 2777, 2780, 2784–2786, 2788, 2797, 2803, 2809, 2817–2818, 2820, 2843, 2852–2853, 2855–2856, 2858, 2865, 2871–2879, 2881–2882, 2889–2893, 2895, 2898, 2913, 2920, 2926, 2934–2937, 2939, 2959–2961, 2999–3000, 3034–3035, 3043, 3088, 3097, 3108–3109, 3111–3113, 3115, 3137, 3139, 3141, 3170–3171, 3243, 3245, 3262–3266, 3268–3273, 3275–3284, 3286–3288, 3292–3294, 3298–3300, 3304–3306, 3310–3312, 3317–3320, 3322–3323, 3328, 3334, 3340, 3348, 3350, 3352, 3397, 3400, 3405, 3412–3417, 3419, 3422–3427, 3431–3436, 3438, 3466, 3474–3475, 3498–3501, 3503–3505, 3507–3510, 3514–3516, 3518–3520, 3522–3525, 3556, 3564, 3570, 3578, 3580–3582, 3584, 3678, 3714–3715, 3730–3732, 3734, 3736, 3738, 3742–3744, 3746–3748, 3750, 3752, 3765, 3791–3795, 3797, 3810–3811, 3817–3819, 3821, 3823–3827, 3838–3858, 3860–3864, 3866, 3876–3877, 3879, 3885–3888, 3890–3894, 3896, 3921–3922, 3928–3929, 3937, 3940–3944, 3953, 3955, 3965, 4038–4040, 4051, 4055, 4065, 4081, 4085–4086, 4088, 4090, 4126, 4131–4133, 4135, 4137, 4139, 4145, 4159–4169, 4171–4175, 4177, 4182–4189, 4191–4193, 4196–4198, 4201–4202, 4204–4206, 4209–4211, 4214–4215, 4217–4218, 4221–4222, 4224–4225, 4228–4229, 4231, 4259, 4261, 4265, 4267, 4269, 4274, 4337, 4341, 4350, 4352, 4354, 4358, 4363–4364, 4366, 4368, 4370, 4372–4373, 4377, 4389, 4393–4394, 4409, 4442, 4446–4447, 4449–4450, 4452, 4456, 4467, 4469, 4473, 4527, 4531, 4589, 4603, 4609, 4615, 4622–4623, 4625, 4642, 4649, 4652, 4658, 4665–4670, 4672, 4674, 4681–4686, 4688, 4704–4705, 4716–4718, 4721–4723, 4732–4736, 4765, 4773, 4779, 4786–4789, 4791, 4804, 4809–4811, 4814–4815, 4818, 4820–4823, 4825, 4831, 4838–4839, 4841–4844, 4846, 4848, 4865, 4913, 4936–4938, 4940, 4946–4947, 4949, 4955, 4962–4963, 4965, 4967, 4981–4984, 4986, 4988, 4994–4995, 4997, 5003, 5010–5014, 5016, 5018, 5021, 5023–5024, 5026, 5028, 5033, 5047–5049, 5051, 5057–5058, 5060, 5066, 5073–5077, 5079, 5081, 5099–5101, 5103–5105, 5124, 5130–5131, 5133–5138, 5144, 5151–5159, 5161–5162, 5165, 5168–5171, 5173, 5175–5177, 5182, 5211, 5213–5216, 5218, 5220, 5225, 5227–5229, 5231, 5249, 5251, 5253, 5255, 5257, 5261, 5263, 5265, 5267, 5269, 5273, 5275, 5277, 5279, 5281, 5283, 5290, 5292–5295, 5297, 5299, 5304, 5306, 5308–5309, 5319–5320, 5322, 5324–5326, 5328–5330, 5369, 5371–5373, 5375–5379, 5381–5383, 5385–5387, 5389–5391, 5393–5396, 5398–5401, 5403–5405, 5407–5409, 5412, 5415–5417, 5433, 5435, 5438, 5441, 5494, 5506–5507, 5509, 5511, 5552–5553, 5557, 5562, 5602–5604, 5606–5609, 5611, 5613, 5618, 5620–5622, 5624, 5655, 5661, 5663, 5665, 5669, 5679, 5683, 5691, 5697, 5701, 5703, 5707, 5709, 5711, 5717, 5735–5741, 5743, 5745–5748, 5750, 5752, 5757, 5759, 5761–5762, 5772–5773, 5776, 5778–5780, 5782–5784, 5787, 5809, 5811, 5817, 5821, 5825, 5837, 5841, 5847, 5856, 5860, 5864, 5869, 5875–5876, 5878–5881, 5883, 5890–5903, 5939, 5945, 5949, 5953–5960, 5962, 5964, 5968, 5972–5980, 5982–5985, 5987, 5989–5990, 5997–6002, 6004, 6006, 6020, 6023, 6030, 6034, 6036, 6039–6040, 6042–6048, 6050, 6053, 6059–6060, 6062–6065, 6067, 6072–6073, 6079–6080, 6087–6091, 6093–6095, 6097–6100, 6102, 6114, 6121–6122, 6129–6137, 6139, 6155, 6164–6167, 6169–6170, 6177–6185, 6187, 6189, 6191–6193, 6195–6196, 6202–6207, 6209, 6243, 6249, 6254, 6258–6259, 6266–6268, 6270–6271, 6273, 6287, 6294–6295, 6302–6307, 6311, 6342, 6344, 6350–6352, 6354, 6366, 6371–6372, 6374, 6380, 6387–6389, 6391, 6393, 6395, 6399–6400, 6403, 6413, 6418, 6423–6424, 6426, 6432, 6439–6443, 6445, 6448–6456, 6458–6459, 6461–6462, 6465, 6477, 6482–6484, 6490, 6497, 6499, 6501, 6505–6506, 6508, 6518, 6523, 6528–6530, 6535, 6542–6544, 6546, 6550–6558, 6560–6561, 6563–6564, 6566, 6604, 6610–6612, 6617, 6624–6626, 6628, 6630, 6633–6634, 6636, 6646, 6651, 6656–6658, 6663, 6670–6673, 6676–6684, 6686–6687, 6689, 6691, 6693, 6705, 6711–6712, 6714, 6719, 6726–6730, 6732, 6734, 6737–6738, 6740, 6750, 6755, 6760–6762, 6767, 6774–6776, 6778, 6781–6783, 6786–6787, 6789–6790, 6792–6793, 6795, 6806, 6811–6813, 6818, 6823, 6828, 6834, 6841, 6843–6844, 6846–6848, 6855, 6860, 6873, 6878, 6880, 6887–6891, 6893–6895, 6906–6907, 6926, 6929–6944, 6946, 6958–6960, 6982, 6988, 6993–6994, 7010–7012, 7021–7027, 7032–7034, 7039, 7041, 7044–7050, 7055–7057, 7062–7063, 7066–7072, 7077–7079, 7084–7085, 7088–7094, 7099–7101, 7106–7107, 7110–7115, 7120–7121, 7126–7127, 7130–7136, 7141–7143, 7148–7149, 7216, 7221, 7232, 7238, 7240, 7244–7247, 7249, 7251–7259, 7275, 7291, 7294, 7312, 7316–7350, 7362, 7365–7366, 7373, 7380, 7382, 7386–7388, 7390–7391, 7393–7396, 7400, 7402, 7406–7408, 7411, 7456, 7466–7467, 7477, 7484, 7486, 7490–7491, 7493–7494, 7496–7497, 7500, 7514, 7521, 7523, 7527–7530, 7532–7533, 7536, 7550, 7557, 7559, 7563–7568, 7572, 7586, 7593, 7595, 7606, 7609–7614, 7616, 7627–7632, 7634, 7638–7640, 7642–7643, 7647–7648, 7661, 7663–7665, 7668, 7687–7688, 7692–7693, 7698, 7704, 7706, 7711, 7718, 7720, 7724–7726, 7728–7730, 7735–7736, 7739, 7741–7744, 7746, 7748, 7763, 7778, 7780, 7785, 7794, 7796, 7800–7801, 7803, 7810, 7820, 7822, 7826–7827, 7831, 7871, 7877–7880, 7895, 7910, 7912, 7916–7917, 7922, 7939, 7941, 7945–7946, 7951, 7992, 7994, 7998–7999, 8004, 8065, 8067, 8071–8072, 8077, 8094, 8096, 8100–8101, 8106, 8114, 8116, 8120–8121, 8125–8127, 8135–8136, 8144, 8162, 8164, 8170, 8172–8173, 8184, 8202, 8210–8214, 8217, 8221, 8227, 8233, 8239–8241, 8254, 8258, 8260–8262, 8276, 8285, 8293–8295, 8297, 8300–8302, 8306, 8310–8312, 8315, 8319, 8325, 8331–8332, 8335, 8376–8378, 8381, 8392, 8399, 8404, 8422, 8425, 8431–8432, 8442–8443, 8453–8454, 8463–8472, 8476, 8482–8483, 8492–8493, 8501, 8507, 8512, 8516–8519, 8521, 8523, 8527–8528, 8530, 8540, 8574–8575, 8577–8578, 8581, 8583–8588, 8590, 8599–8600, 8613–8614, 8729, 8751, 8768, 8832, 8855–8856, 8864–8865, 8890, 8902, 8916–8918, 8933, 8938–8940, 8969, 8980–8981, 8985, 8999–9000, 9006, 9046–9050, 9056, 9063–9066, 9069–9071, 9073, 9083, 9089–9091, 9093–9094, 9096, 9104, 9106, 9108, 9110, 9148, 9159–9160, 9291, 9620, 9879, 9882, 10057, 10185, 10195, 10240, 10338, 10345–10347, 10351, 10358–10360, 10381, 10388–10390, 10426, 10429–10430, 10532, 10539–10541, 10571–10573, 10575, 10578–10579, 10586, 10603–10606, 10612–10613, 10620, 10638–10641, 10647–10648, 10655, 10866–10868, 10870–10873, 10875, 10877–10878, 10880–10881, 10885–10886, 10896, 10986–10989, 10994, 11034, 11075, 11191, 11193–11195, 11214, 11229–11231, 11237, 11318–11319, 11321, 11333, 11345, 11357, 11371, 11383, 11395, 11409, 11423, 11437, 11452, 11474, 11476, 11501, 11521, 11532, 11542, 11553, 11570, 11588, 11610, 11628, 11644, 11664, 11686, 11701, 11711, 11747, 11761, 11780, 11799, 11835, 11854, 11865–11870, 11872, 11896, 11908–11909, 11911–11912, 11919–11921, 11925–11926, 11928–11929, 11933, 11990, 12058, 12087, 12100, 12120–12123, 12127, 12135–12140, 12146–12151, 12186, 12196, 12199, 12233–12240, 12243, 12245–12247, 12268, 12273–12276, 12286, 12290, 12294, 12321, 12332, 12367, 12420, 12583–12586, 12664, 12703, 12807, 12867, 12878, 12972, 12974, 12996–12999, 13003, 13053, 13125, 13149, 13185, 13231, 13601, 13628–13629, 13671, 13705–13706, 13708–13710, 13717–13719, 13725, 13752–13755, 13799, 13801–13802, 13805, 13808–13812, 13814, 13816–13819, 14137, 14139–14145, 14147–14148, 14152
TOTAL	5819	2181	62%

Tests	Skipped	Failures	Errors	Time
300	0 💤	0 ❌	0 🔥	4.943s ⏱️

[dantavori]

nice, let's ask for a doc review
will re-review after the demo

[ShirleyDenkberg]

@dantavori @jlevypaloalto Doc review completed.