Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JoeSecurityv2 fixed filename and comment #32819

Merged
merged 20 commits into from Feb 25, 2024
Merged

Conversation

JasBeilin
Copy link
Contributor

@JasBeilin JasBeilin commented Feb 11, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Fixed an issue where we used wrong argument name and didn't use the filename in the submit call.

Must have

  • Tests
  • Documentation

@JasBeilin JasBeilin self-assigned this Feb 11, 2024
Copy link

github-actions bot commented Feb 11, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/JoeSecurity/Integrations/JoeSecurityV2
   JoeSecurityV2.py3068871%26, 39, 59, 61, 63, 67, 91, 139–146, 181, 183, 188–190, 193–195, 209–217, 232, 285, 320, 345, 357–360, 362, 429–434, 436–445, 448, 561–566, 579, 646–648, 669, 721, 745, 768, 787, 806, 824, 838–843, 845, 847, 863–865, 870, 872
TOTAL3068871% 

Tests Skipped Failures Errors Time
29 0 💤 0 ❌ 0 🔥 1.865s ⏱️

@JasBeilin
Copy link
Contributor Author

Need Force due to oncall known issue.

@yuvalbenshalom yuvalbenshalom merged commit 7a5cb50 into master Feb 25, 2024
15 of 17 checks passed
@yuvalbenshalom yuvalbenshalom deleted the jb_joe_security_fix branch February 25, 2024 15:46
maimorag pushed a commit that referenced this pull request Feb 26, 2024
* fixed filename and comment

* Update Packs/JoeSecurity/Integrations/JoeSecurityV2/JoeSecurityV2.py

* test

* issue fix

* Update README.md

* Update README.md

* fix comment argument

* RN

* fix

* Update JoeSecurityV2.py

* fix pre commit
rundssoar pushed a commit to rundssoar/content that referenced this pull request Feb 28, 2024
* fixed filename and comment

* Update Packs/JoeSecurity/Integrations/JoeSecurityV2/JoeSecurityV2.py

* test

* issue fix

* Update README.md

* Update README.md

* fix comment argument

* RN

* fix

* Update JoeSecurityV2.py

* fix pre commit
maimorag pushed a commit that referenced this pull request Feb 28, 2024
* fixed filename and comment

* Update Packs/JoeSecurity/Integrations/JoeSecurityV2/JoeSecurityV2.py

* test

* issue fix

* Update README.md

* Update README.md

* fix comment argument

* RN

* fix

* Update JoeSecurityV2.py

* fix pre commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants