Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XSUP-32897 #32824

Merged
merged 12 commits into from Mar 20, 2024
Merged

XSUP-32897 #32824

merged 12 commits into from Mar 20, 2024

Conversation

kobymeir
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

related: https://jira-dc.paloaltonetworks.com/browse/XSUP-32897

Description

XSUP-32897

@kobymeir kobymeir self-assigned this Feb 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2024 •
edited

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/EmailCommunication/Scripts/SendEmailReply
   SendEmailReply.py4269078%47, 123–124, 128, 150, 198, 216, 219, 241–244, 275, 310, 315, 373–374, 376–377, 381–392, 394, 466, 468, 471, 520–524, 542–543, 546, 560, 562, 564–569, 571, 573, 583–588, 596–597, 705–706, 773–774, 816, 820, 829, 833–837, 841–845, 879, 884, 913, 937, 960, 963, 976–977, 1019, 1040–1042
TOTAL4269078% 

Tests Skipped Failures Errors Time
56 0 💤 0 ❌ 0 🔥 2.708s ⏱️

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • EmailCommunication pack version was bumped to 2.0.26.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

tkatzir
tkatzir reviewed Mar 3, 2024
View reviewed changes
Copy link
Contributor

@tkatzir tkatzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible loop in get_unique_code.

tkatzir
tkatzir approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@tkatzir tkatzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Approved, with some important comments.

Packs/EmailCommunication/ReleaseNotes/2_0_26.md Outdated Show resolved Hide resolved
Packs/EmailCommunication/Scripts/SendEmailReply/SendEmailReply.py Outdated Show resolved Hide resolved
Packs/EmailCommunication/Scripts/SendEmailReply/SendEmailReply.py Outdated Show resolved Hide resolved
Packs/EmailCommunication/Scripts/SendEmailReply/SendEmailReply.py Outdated Show resolved Hide resolved
Packs/EmailCommunication/Scripts/SendEmailReply/SendEmailReply.py Outdated Show resolved Hide resolved
Packs/EmailCommunication/Scripts/SendEmailReply/SendEmailReply.py Outdated Show resolved Hide resolved
Packs/EmailCommunication/Scripts/SendEmailReply/SendEmailReply.py Show resolved Hide resolved
Packs/EmailCommunication/Scripts/SendEmailReply/SendEmailReply.py Outdated Show resolved Hide resolved
Packs/EmailCommunication/Scripts/SendEmailReply/SendEmailReply.py Outdated Show resolved Hide resolved
kobymeir and others added 2 commits March 4, 2024 17:27
@kobymeir kobymeir marked this pull request as ready for review March 20, 2024 05:44
@kobymeir kobymeir merged commit 1aeae17 into master Mar 20, 2024
20 of 21 checks passed
@kobymeir kobymeir deleted the XSUP-32897 branch March 20, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkatzir tkatzir tkatzir approved these changes

Assignees

@kobymeir kobymeir

Labels
docs-approved
Projects
None yet
Milestone
No milestone
3 participants
@kobymeir @content-bot @tkatzir