Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSIAM Refactor Generic Data Model Queries CRTX-103883 #32830

Merged
merged 15 commits into from Feb 12, 2024

Conversation

cweltPA
Copy link
Contributor

@cweltPA cweltPA commented Feb 11, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CRTX-103883

Description

This PR transforms generic datamodel XQL queries in dashboards & correlation rule which do not target a specific dataset but rather filter the search based on the normalized vendor & product as an -
| datamodel | filter xdm.observer.vendor = <MyVendor> and xdm.observer.product = <MyProduct>

into an improved form which queries the target dataset explicitly:
| datamodel dataset = <MyVendor>_<MyProduct>_raw

The latter query wasn't fully supported previously when the target dataset did not yet exist on the target tenant, but now however it is, so we could implement this query format which would improve run-time performance significantly, as the filtering is done on the target dataset directly rather then normalizing the data from all datasets and only then applying the filter.

The PR handles all dashboards and correlation rules that contains such XQL queries that of today,
the following packs are affected -

  1. AlibabaActionTrail.
  2. CyberArkIdentity.
  3. Dropbox.
  4. GitLab.
  5. GoogleChrome.
  6. MicrosoftDefenderAdvancedThreatProtection.

Must have

  • Tests
  • Documentation

@cweltPA cweltPA self-assigned this Feb 12, 2024
@cweltPA cweltPA merged commit 52089cf into master Feb 12, 2024
16 checks passed
@cweltPA cweltPA deleted the xsiam-refactor-generic-datamodel-queries-crtx-103883 branch February 12, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants