Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the maximum page size from the docs #32869

Merged
merged 8 commits into from Feb 15, 2024

Conversation

RosenbergYehuda
Copy link
Contributor

@RosenbergYehuda RosenbergYehuda commented Feb 13, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

In the description of the page_size argument (written by me), it stated that the maximum size per page restricted by the API is 1000 results. However, since I did not find official documentation confirming this, and after observing a client attempting to use a page size of 1000 but receiving only 500, I am removing that information from the description to prevent user misunderstanding.

Must have

  • Tests
  • Documentation

@ShirleyDenkberg
Copy link
Contributor

@JasBeilin Doc review completed.

@RosenbergYehuda RosenbergYehuda merged commit 2ea3cc7 into master Feb 15, 2024
16 checks passed
@RosenbergYehuda RosenbergYehuda deleted the YR/Remove-the-maximum-page-size-from-the-docs branch February 15, 2024 16:07
maimorag pushed a commit that referenced this pull request Feb 22, 2024
* remove the maximum

* RN

* Shirley

* format

* RN
maimorag pushed a commit that referenced this pull request Feb 28, 2024
* remove the maximum

* RN

* Shirley

* format

* RN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants