Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXPANDR-8026: Azure Remediation Bug Fix and Improvements #32941

Merged
merged 3 commits into from Feb 18, 2024
Merged

EXPANDR-8026: Azure Remediation Bug Fix and Improvements #32941

merged 3 commits into from Feb 18, 2024

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@johnnywilkes

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-8026
https://jira-dc.paloaltonetworks.com/browse/EXPANDR-8017
https://jira-dc.paloaltonetworks.com/browse/EXPANDR-7540

Description

  • Added the SubscriptionID and ResourceGroup optional inputs in case the subscription ID and/or resource group needs to be specified.
  • Add the remediatedFlag and remediatedReason outputs to supply information on whether the remediation action was successful and additional information to the parent playbook.
  • Fixed an issue with not being able to detect all offending rules.

Must have

  • Tests
  • Documentation

@johnnywilkes @ShirleyDenkberg
EXPANDR-8026: Azure Remediation Bug Fix and Improvements (#32882)
f17778d 
* update files

* RN

* RN part 2

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Contribution Form Filled Whether contribution form filled or not. Community Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR Security Review labels Feb 14, 2024
@yucohen yucohen merged commit f31d03f into master Feb 18, 2024
15 of 16 checks passed
@yucohen yucohen deleted the contrib/PaloAltoNetworks_Azure-EXPANDR-8026 branch February 18, 2024 07:17
MosheEichler pushed a commit that referenced this pull request Feb 19, 2024
@content-bot @johnnywilkes
@ShirleyDenkberg @yucohen @MosheEichler
EXPANDR-8026: Azure Remediation Bug Fix and Improvements (#32882) (#3…
e348f10 
…2941)

* update files

* RN

* RN part 2

* Apply suggestions from code review



---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com>
MosheEichler added a commit that referenced this pull request Feb 20, 2024
@MosheEichler @MLainer1
@content-bot @johnnywilkes @ShirleyDenkberg @yucohen
Add nightly ok label workflow (#32876)
6b2e5af 
* Add nightly ran GitHub workflow

* change label name

* change label name

* update message

* remove continue on error

* changed gitlab

* update workflow

* change name

* typo

* Update on call to Edri&Polishuk (#32964)

* bug - Cortex IR resolved incidents not mirrored correctly (#32856)

* bug - Cortex IR resolved incidents not mirrored correctly

* Possible fix

* RN

* Bump pack from version CortexXDR to 6.1.16.

* pre commit

* rn

* pre-commit

* fix test

* pre commit

---------

Co-authored-by: Content Bot <bot@demisto.com>

* Update Docker Image To demisto/taxii-server  (#32897)

* Updated Metadata Of Pack CybleThreatIntel

* Added release notes to pack CybleThreatIntel

* Packs/CybleThreatIntel/Integrations/CybleThreatIntel/CybleThreatIntel.yml Docker image update

* EXPANDR-8026: Azure Remediation Bug Fix and Improvements (#32882) (#32941)

* update files

* RN

* RN part 2

* Apply suggestions from code review



---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com>

* change to run

* cr fixes

* fix git diff

* add git checkout

* origin

* github event

* chckout

* master

* GITHUB_REF

* change name

* only master

* fetch origin master

* remove print

* chekcout

* 0

* fi

* add origin

* fix syntax

* revert gitlab

* add if

* change else

* curl brackets

* remove n

* $GITHUB_OUTPUT

* gitlab change

* print

* revert

* add changed files null

* commit

* echo

* comment

* without grep

* fix

* new line

* gitlab changed

* remove ^

* remove "

* gitlab/ci

* use *

* GITLAB_CHANGED_FILES

* fix check

* console log outputs

* fix logs

* add $

* remove logs

* remove true

* revert

* log

* impement if

* add brackets

* gitlab

* revert gitlab

---------

Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
Co-authored-by: content-bot <55035720+content-bot@users.noreply.github.com>
Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com>
maimorag pushed a commit that referenced this pull request Feb 22, 2024
@content-bot @johnnywilkes
@ShirleyDenkberg @yucohen @maimorag
EXPANDR-8026: Azure Remediation Bug Fix and Improvements (#32882) (#3…
2bfdfa1 
…2941)

* update files

* RN

* RN part 2

* Apply suggestions from code review



---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com>
maimorag pushed a commit that referenced this pull request Feb 22, 2024
@MosheEichler @MLainer1
@content-bot @johnnywilkes @ShirleyDenkberg @yucohen @maimorag
Add nightly ok label workflow (#32876)
9e7ab4d 
* Add nightly ran GitHub workflow

* change label name

* change label name

* update message

* remove continue on error

* changed gitlab

* update workflow

* change name

* typo

* Update on call to Edri&Polishuk (#32964)

* bug - Cortex IR resolved incidents not mirrored correctly (#32856)

* bug - Cortex IR resolved incidents not mirrored correctly

* Possible fix

* RN

* Bump pack from version CortexXDR to 6.1.16.

* pre commit

* rn

* pre-commit

* fix test

* pre commit

---------

Co-authored-by: Content Bot <bot@demisto.com>

* Update Docker Image To demisto/taxii-server  (#32897)

* Updated Metadata Of Pack CybleThreatIntel

* Added release notes to pack CybleThreatIntel

* Packs/CybleThreatIntel/Integrations/CybleThreatIntel/CybleThreatIntel.yml Docker image update

* EXPANDR-8026: Azure Remediation Bug Fix and Improvements (#32882) (#32941)

* update files

* RN

* RN part 2

* Apply suggestions from code review



---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com>

* change to run

* cr fixes

* fix git diff

* add git checkout

* origin

* github event

* chckout

* master

* GITHUB_REF

* change name

* only master

* fetch origin master

* remove print

* chekcout

* 0

* fi

* add origin

* fix syntax

* revert gitlab

* add if

* change else

* curl brackets

* remove n

* $GITHUB_OUTPUT

* gitlab change

* print

* revert

* add changed files null

* commit

* echo

* comment

* without grep

* fix

* new line

* gitlab changed

* remove ^

* remove "

* gitlab/ci

* use *

* GITLAB_CHANGED_FILES

* fix check

* console log outputs

* fix logs

* add $

* remove logs

* remove true

* revert

* log

* impement if

* add brackets

* gitlab

* revert gitlab

---------

Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
Co-authored-by: content-bot <55035720+content-bot@users.noreply.github.com>
Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com>
maimorag pushed a commit that referenced this pull request Feb 28, 2024
@content-bot @johnnywilkes
@ShirleyDenkberg @yucohen @maimorag
EXPANDR-8026: Azure Remediation Bug Fix and Improvements (#32882) (#3…
ec41f0f 
…2941)

* update files

* RN

* RN part 2

* Apply suggestions from code review



---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com>
maimorag pushed a commit that referenced this pull request Feb 28, 2024
@MosheEichler @MLainer1
@content-bot @johnnywilkes @ShirleyDenkberg @yucohen @maimorag
Add nightly ok label workflow (#32876)
f7b0378 
* Add nightly ran GitHub workflow

* change label name

* change label name

* update message

* remove continue on error

* changed gitlab

* update workflow

* change name

* typo

* Update on call to Edri&Polishuk (#32964)

* bug - Cortex IR resolved incidents not mirrored correctly (#32856)

* bug - Cortex IR resolved incidents not mirrored correctly

* Possible fix

* RN

* Bump pack from version CortexXDR to 6.1.16.

* pre commit

* rn

* pre-commit

* fix test

* pre commit

---------

Co-authored-by: Content Bot <bot@demisto.com>

* Update Docker Image To demisto/taxii-server  (#32897)

* Updated Metadata Of Pack CybleThreatIntel

* Added release notes to pack CybleThreatIntel

* Packs/CybleThreatIntel/Integrations/CybleThreatIntel/CybleThreatIntel.yml Docker image update

* EXPANDR-8026: Azure Remediation Bug Fix and Improvements (#32882) (#32941)

* update files

* RN

* RN part 2

* Apply suggestions from code review



---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com>

* change to run

* cr fixes

* fix git diff

* add git checkout

* origin

* github event

* chckout

* master

* GITHUB_REF

* change name

* only master

* fetch origin master

* remove print

* chekcout

* 0

* fi

* add origin

* fix syntax

* revert gitlab

* add if

* change else

* curl brackets

* remove n

* $GITHUB_OUTPUT

* gitlab change

* print

* revert

* add changed files null

* commit

* echo

* comment

* without grep

* fix

* new line

* gitlab changed

* remove ^

* remove "

* gitlab/ci

* use *

* GITLAB_CHANGED_FILES

* fix check

* console log outputs

* fix logs

* add $

* remove logs

* remove true

* revert

* log

* impement if

* add brackets

* gitlab

* revert gitlab

---------

Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
Co-authored-by: content-bot <55035720+content-bot@users.noreply.github.com>
Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yucohen yucohen yucohen approved these changes

Assignees

@melamedbn melamedbn

@yucohen yucohen

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
4 participants
@content-bot @yucohen @melamedbn @johnnywilkes