Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhishTank v2 - Added the username parameter #32951

Merged
merged 12 commits into from Feb 19, 2024
Merged

PhishTank v2 - Added the username parameter #32951

merged 12 commits into from Feb 19, 2024

Conversation

adi88d
Copy link
Contributor

@adi88d adi88d commented Feb 15, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue
link to the issue

Description

Added a new parameter username. Allows to add the phishtank user to the requests header in order to increase the rate limit.
for more info see this API docs

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Feb 15, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/PhishTank/Integrations/PhishTankV2
   PhishTankV2.py1726164%20–24, 47, 69–72, 74, 128–138, 140–143, 195–204, 298, 320–326, 328–329, 333, 335–336, 338–340, 342–344, 346–347, 349–350, 353–354
TOTAL1726164% 

Tests Skipped Failures Errors Time
28 0 💤 0 ❌ 0 🔥 2.027s ⏱️

@@ -0,0 +1,4 @@
#### Integrations
##### PhishTank v2
- Added a new parameter **username**. Allows to add the phishtank user to the requests header in order to increase the rate limit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Added a new parameter **username**. Allows to add the phishtank user to the requests header in order to increase the rate limit.
- Added a new parameter *username*. Allows adding the PhishTank user to the requests header in order to increase the rate limit.

@ShirleyDenkberg
Copy link
Contributor

@DeanArbel Doc review completed.

@adi88d adi88d merged commit 425775f into master Feb 19, 2024
16 checks passed
@adi88d adi88d deleted the fix-phishtank branch February 19, 2024 20:50
maimorag pushed a commit that referenced this pull request Feb 22, 2024
* added the username parameter

* update docker

* set username as optional

* doc review

* add test_user_agent_header

* flake8
maimorag pushed a commit that referenced this pull request Feb 28, 2024
* added the username parameter

* update docker

* set username as optional

* doc review

* add test_user_agent_header

* flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants