fix(sekoiaio/cti): return None for unknown indicator #32953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(sekoiaio/cti): properly return unknown indicator * fix(sekoiaio/cti): properly return unknown indicator * Apply review suggestion by @sapirshuker * Apply review suggestion by @sapirshuker * Apply review suggestion by @sapirshuker * Apply review suggestion by @sapirshuker * fix(sekoiacti): fix tests and bump version * Apply review suggestion by @sapirshuker * Apply review suggestion by @sapirshuker * Revert "Apply review suggestion by @sapirshuker" This reverts commit 8ec89e6. * Apply review suggestion by @sapirshuker * Bump version and Docker image * Fix CI
content-bot
added
Contribution
Coverage Report
|
||||||||||||||||||||||||||||||
sapirshuker
approved these changes
Feb 18, 2024
sapirshuker
deleted the
contrib/SEKOIA-IO_sekoia-io-cti-unknown-indicator
branch
maimorag
pushed a commit
that referenced
this pull request
Feb 22, 2024
* fix(sekoiaio/cti): properly return unknown indicator * fix(sekoiaio/cti): properly return unknown indicator * Apply review suggestion by @sapirshuker * Apply review suggestion by @sapirshuker * Apply review suggestion by @sapirshuker * Apply review suggestion by @sapirshuker * fix(sekoiacti): fix tests and bump version * Apply review suggestion by @sapirshuker * Apply review suggestion by @sapirshuker * Revert "Apply review suggestion by @sapirshuker" This reverts commit 8ec89e6. * Apply review suggestion by @sapirshuker * Bump version and Docker image * Fix CI Co-authored-by: lilyus <8960084+PierrickV@users.noreply.github.com>
maimorag
pushed a commit
that referenced
this pull request
Feb 28, 2024
* fix(sekoiaio/cti): properly return unknown indicator * fix(sekoiaio/cti): properly return unknown indicator * Apply review suggestion by @sapirshuker * Apply review suggestion by @sapirshuker * Apply review suggestion by @sapirshuker * Apply review suggestion by @sapirshuker * fix(sekoiacti): fix tests and bump version * Apply review suggestion by @sapirshuker * Apply review suggestion by @sapirshuker * Revert "Apply review suggestion by @sapirshuker" This reverts commit 8ec89e6. * Apply review suggestion by @sapirshuker * Bump version and Docker image * Fix CI Co-authored-by: lilyus <8960084+PierrickV@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@PierrickV
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Related to PR #30345 reviewed by @sapirshuker, @Ni-Knight, @MLainer1, @ilaner, @dorschw
Must have