Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Cloud Watch logs - fix proxy issue #32956

Conversation

Enigmatyk
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • [] In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Fixed an issue where the proxy setting was not present.

Description

Fixed an issue where the proxy setting was not present.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Feb 15, 2024
@content-bot content-bot changed the base branch from master to contrib/Enigmatyk_aws_cloud_watch_fix_proxy February 15, 2024 17:25
@Enigmatyk Enigmatyk marked this pull request as draft February 16, 2024 09:54
@Enigmatyk Enigmatyk marked this pull request as ready for review February 16, 2024 09:54
@shmuel44 shmuel44 assigned JudahSchwartz and unassigned shmuel44 Feb 16, 2024
@JudahSchwartz JudahSchwartz requested review from merit-maita and removed request for JudahSchwartz February 18, 2024 07:59
Copy link
Contributor

@merit-maita merit-maita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution!
it looks good, please see my comments.

@merit-maita merit-maita added the pending-contributor The PR is pending the response of its creator label Feb 18, 2024
Enigmatyk and others added 3 commits February 19, 2024 12:05
…loudWatchLogs.yml

Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>
Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>
Copy link
Contributor

@merit-maita merit-maita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as seen in the pr checks, there's a conflict
a new version of the pack was released very recently, with the same version as yours, so please change your version to be 1_2_20.md and in pack_metadata file as well.
thank you!

@merit-maita merit-maita added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Feb 20, 2024
@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/839205

@merit-maita merit-maita merged commit e98aa4a into demisto:contrib/Enigmatyk_aws_cloud_watch_fix_proxy Feb 20, 2024
21 of 23 checks passed
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

merit-maita added a commit that referenced this pull request Feb 20, 2024
* fix proxy issue

* format yml

* Update Packs/AWS-CloudWatchLogs/Integrations/AWS-CloudWatchLogs/AWS-CloudWatchLogs.yml



* Update Packs/AWS-CloudWatchLogs/ReleaseNotes/1_2_19.md



* format and ReleaseNotes

* ReleaseNotes

* add 1_2_20

---------

Co-authored-by: Fábio Dias <henrique.cannavaro@gmail.com>
Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
maimorag pushed a commit that referenced this pull request Feb 22, 2024
* fix proxy issue

* format yml

* Update Packs/AWS-CloudWatchLogs/Integrations/AWS-CloudWatchLogs/AWS-CloudWatchLogs.yml



* Update Packs/AWS-CloudWatchLogs/ReleaseNotes/1_2_19.md



* format and ReleaseNotes

* ReleaseNotes

* add 1_2_20

---------

Co-authored-by: Fábio Dias <henrique.cannavaro@gmail.com>
Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
maimorag pushed a commit that referenced this pull request Feb 28, 2024
* fix proxy issue

* format yml

* Update Packs/AWS-CloudWatchLogs/Integrations/AWS-CloudWatchLogs/AWS-CloudWatchLogs.yml



* Update Packs/AWS-CloudWatchLogs/ReleaseNotes/1_2_19.md



* format and ReleaseNotes

* ReleaseNotes

* add 1_2_20

---------

Co-authored-by: Fábio Dias <henrique.cannavaro@gmail.com>
Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
5 participants