Fix AWSRecreateSG EC2 breaking change bug #32962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
||||||||||||||||||||||||||||||
johnnywilkes
suggested changes
Feb 16, 2024
Packs/AWS-Enrichment-Remediation/Scripts/AWSRecreateSG/AWSRecreateSG.py
Outdated
Show resolved
Hide resolved
johnnywilkes
approved these changes
Feb 21, 2024
JudahSchwartz
approved these changes
Feb 22, 2024
johnnywilkes
suggested changes
Feb 23, 2024
johnnywilkes
approved these changes
Feb 26, 2024
rundssoar
pushed a commit
to rundssoar/content
that referenced
this pull request
Feb 28, 2024
* fixed * remove print * update docker + RN * add BC warning * remove duplicate * fixed unit-tests * newline
maimorag
pushed a commit
that referenced
this pull request
Feb 28, 2024
* fixed * remove print * update docker + RN * add BC warning * remove duplicate * fixed unit-tests * newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
AWSRecreateSG fails after the recent changes to
AWS - EC2(version 1.3.0)The problems are caused by the change in the object returned when
AWS - EC2commands are called using thedemisto.executeCommandfunction in the script . This PR uses a new path to extract the required data correctly.Must have