Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IdentifyAttachedEmail handle None #32966

Merged
merged 5 commits into from Feb 18, 2024
Merged

Conversation

anara123
Copy link
Contributor

@anara123 anara123 commented Feb 17, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-33546

Description

Fixed an issue where the API was returning None for entries, and the code didn't handle None case

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Feb 17, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CommonScripts/Scripts/IdentifyAttachedEmail
   IdentifyAttachedEmail.py51688%18–19, 28, 83–85
TOTAL51688% 

Tests Skipped Failures Errors Time
8 0 💤 0 ❌ 0 🔥 1.184s ⏱️

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.14.0.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@anara123
Copy link
Contributor Author

Force merging since the same is as here https://jira-dc.paloaltonetworks.com/browse/CIAC-9695

@anara123 anara123 merged commit 2a982b9 into master Feb 18, 2024
20 of 22 checks passed
@anara123 anara123 deleted the fix-identify-attached-email branch February 18, 2024 15:55
maimorag pushed a commit that referenced this pull request Feb 22, 2024
* fix IdentifyAttachedEmail handle None

* fix docker

* add coverage

* Bump pack from version CommonScripts to 1.14.0.

---------

Co-authored-by: Content Bot <bot@demisto.com>
maimorag pushed a commit that referenced this pull request Feb 28, 2024
* fix IdentifyAttachedEmail handle None

* fix docker

* add coverage

* Bump pack from version CommonScripts to 1.14.0.

---------

Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants