Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] - threatconnect feed missing indicator type parser #32993

Merged
merged 8 commits into from Feb 21, 2024

Conversation

MLainer1
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Feb 19, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/FeedThreatConnect/Integrations/FeedThreatConnect
   FeedThreatConnect.py1772784%176–180, 201, 206, 279, 281, 283, 287, 323, 347–349, 367–371, 373, 477, 483, 494, 498, 510, 549
TOTAL1772784% 

Tests Skipped Failures Errors Time
23 0 💤 0 ❌ 0 🔥 1.286s ⏱️

@MLainer1 MLainer1 marked this pull request as ready for review February 20, 2024 15:25
Packs/FeedThreatConnect/ReleaseNotes/2_1_20.json Outdated Show resolved Hide resolved
Packs/FeedThreatConnect/ReleaseNotes/2_1_20.md Outdated Show resolved Hide resolved
@MLainer1 MLainer1 merged commit a8c7174 into master Feb 21, 2024
21 checks passed
@MLainer1 MLainer1 deleted the bug_threatconnect_feed_indicator_type branch February 21, 2024 15:10
maimorag pushed a commit that referenced this pull request Feb 22, 2024
* [bug] - threatconnect feed missing indicator type parser

* test

* rn

* debug logs

* DI

* revert

* precommit
maimorag pushed a commit that referenced this pull request Feb 28, 2024
* [bug] - threatconnect feed missing indicator type parser

* test

* rn

* debug logs

* DI

* revert

* precommit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants