Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CortexXpanse] Update Integration Fetch Offset #33002

Merged
merged 2 commits into from Feb 20, 2024

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@johnnywilkes

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-8176

Description

We were trying to set a one hour offset before but found that the time is in epoch so this wasn't the case. Also adding debug statements for future tshoot.

Must have

  • Tests
  • Documentation

* Remove 3 second offset

* Add debug logging and remove comments

* changes after convo with John

* docket and RN

* bump ver

* edit RN

* readd old RN

* Update Packs/CortexXpanse/Integrations/CortexXpanse/CortexXpanse.py

Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>

---------

Co-authored-by: bigeasyj <janny@paloaltonetworks.com>
Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Contribution Form Filled Whether contribution form filled or not. Community Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR TIM Review labels Feb 19, 2024
Copy link

github-actions bot commented Feb 19, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CortexXpanse/Integrations/CortexXpanse
   CortexXpanse.py52912177%355, 357, 363–364, 368, 370, 372, 378, 384, 386–387, 393–394, 397, 401–402, 409, 447, 451, 453, 487, 548, 592, 596, 598, 635, 679, 681, 683, 722, 725, 761, 764, 800, 803, 839, 842, 892, 894, 900, 902, 906, 912, 919, 923, 958, 1001, 1060, 1063, 1065, 1070, 1072, 1074–1075, 1077, 1115, 1118, 1123, 1152, 1156, 1167, 1215, 1219, 1230, 1237, 1302, 1304, 1306, 1352–1353, 1355–1360, 1369–1371, 1373–1374, 1381–1382, 1384–1385, 1387–1388, 1393–1401, 1407–1409, 1411–1414, 1421–1426, 1428, 1450–1453, 1463–1466, 1468, 1470–1471
TOTAL52912177% 

Tests Skipped Failures Errors Time
21 0 💤 0 ❌ 0 🔥 1.661s ⏱️

@moishce moishce merged commit f792bfc into master Feb 20, 2024
16 checks passed
@moishce moishce deleted the contrib/PaloAltoNetworks_xpsup-22289 branch February 20, 2024 00:53
maimorag pushed a commit that referenced this pull request Feb 22, 2024
* Remove 3 second offset

* Add debug logging and remove comments

* changes after convo with John

* docket and RN

* bump ver

* edit RN

* readd old RN

* Update Packs/CortexXpanse/Integrations/CortexXpanse/CortexXpanse.py



---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: bigeasyj <janny@paloaltonetworks.com>
Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Co-authored-by: Moshe Galitzky <112559840+moishce@users.noreply.github.com>
maimorag pushed a commit that referenced this pull request Feb 28, 2024
* Remove 3 second offset

* Add debug logging and remove comments

* changes after convo with John

* docket and RN

* bump ver

* edit RN

* readd old RN

* Update Packs/CortexXpanse/Integrations/CortexXpanse/CortexXpanse.py



---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: bigeasyj <janny@paloaltonetworks.com>
Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Co-authored-by: Moshe Galitzky <112559840+moishce@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. TIM Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
3 participants