New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CortexXpanse] Update Integration Fetch Offset #33002
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove 3 second offset * Add debug logging and remove comments * changes after convo with John * docket and RN * bump ver * edit RN * readd old RN * Update Packs/CortexXpanse/Integrations/CortexXpanse/CortexXpanse.py Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com> --------- Co-authored-by: bigeasyj <janny@paloaltonetworks.com> Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
content-bot
added
Contribution
Thank you! Contributions are always welcome!
docs-approved
ready-for-instance-test
In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Contribution Form Filled
Whether contribution form filled or not.
Community
Xsoar Support Level
Indicates that the contribution is for XSOAR supported pack
Internal PR
TIM Review
labels
Feb 19, 2024
Coverage Report
|
moishce
approved these changes
Feb 20, 2024
maimorag
pushed a commit
that referenced
this pull request
Feb 22, 2024
* Remove 3 second offset * Add debug logging and remove comments * changes after convo with John * docket and RN * bump ver * edit RN * readd old RN * Update Packs/CortexXpanse/Integrations/CortexXpanse/CortexXpanse.py --------- Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: bigeasyj <janny@paloaltonetworks.com> Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com> Co-authored-by: Moshe Galitzky <112559840+moishce@users.noreply.github.com>
maimorag
pushed a commit
that referenced
this pull request
Feb 28, 2024
* Remove 3 second offset * Add debug logging and remove comments * changes after convo with John * docket and RN * bump ver * edit RN * readd old RN * Update Packs/CortexXpanse/Integrations/CortexXpanse/CortexXpanse.py --------- Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: bigeasyj <janny@paloaltonetworks.com> Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com> Co-authored-by: Moshe Galitzky <112559840+moishce@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community
Contribution Form Filled
Whether contribution form filled or not.
Contribution
Thank you! Contributions are always welcome!
docs-approved
Internal PR
ready-for-instance-test
In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
TIM Review
Xsoar Support Level
Indicates that the contribution is for XSOAR supported pack
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@johnnywilkes
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
https://jira-dc.paloaltonetworks.com/browse/EXPANDR-8176
Description
We were trying to set a one hour offset before but found that the time is in epoch so this wasn't the case. Also adding debug statements for future tshoot.
Must have