Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix base client execution metrics #33044

Merged
merged 2 commits into from Feb 21, 2024
Merged

fix base client execution metrics #33044

merged 2 commits into from Feb 21, 2024

Conversation

dantavori
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Copy link

github-actions bot commented Feb 21, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Base/Scripts/CommonServerPython
   CommonServerPython.py438465285%167–170, 181, 183, 407, 449, 544, 569–573, 598, 613, 753–754, 763, 804–805, 823, 853–857, 861–863, 905, 992–1000, 1044–1049, 1083–1085, 1215–1219, 1222–1223, 1225–1227, 1241–1243, 1245, 1311, 1324, 1337, 1345–1347, 1349, 1362, 1370, 1457–1458, 1513, 1535–1536, 1539, 1545, 1547, 1549, 1643, 1688, 1762–1765, 1803–1804, 1818–1823, 1825, 1893, 1976, 1978, 1998, 2028, 2032, 2074, 2253, 2277, 2316–2317, 2397–2398, 2400, 2413–2420, 2422, 2499–2501, 2515, 2528, 2559, 2565–2569, 2571–2573, 2575, 2579–2580, 2582, 2595–2601, 2605, 2609–2611, 2617–2618, 2630, 2658, 2661, 2666, 2686, 2692, 2694, 2696, 2716, 2719, 2731, 2777–2785, 2787, 2846, 2868, 2888, 2946, 2958–2959, 3071, 3073, 3248, 3258, 3264, 3273, 3279, 3293, 3349, 3364, 3366, 3397–3402, 3405, 3456–3457, 3460, 3626–3627, 3630, 3737, 3740, 3965, 3968, 3971, 3974, 3979, 3988, 4014, 4020, 4023, 4032, 4034, 4150–4151, 4175, 4177, 4196, 4199, 4202, 4270, 4291, 4293, 4429, 4447, 4459, 4495, 4497, 4671–4672, 4750, 4752, 4777, 4792–4808, 4811, 4815–4816, 4818–4819, 4821–4822, 4824–4825, 4827–4828, 4830–4831, 4833–4834, 4836–4837, 4839–4840, 4842–4843, 4845–4846, 4848–4849, 4851–4852, 4854, 4856–4857, 4859–4862, 4864–4866, 4868, 4870, 4874, 4945, 4977, 4983, 4985, 5023, 5028–5029, 5034, 5038–5039, 5041, 5123, 5129, 5221, 5242, 5245–5250, 5258–5264, 5266–5267, 5312, 5325, 5420–5423, 5428, 5431, 5434, 5468, 5471, 5515, 5517, 5519, 5614, 5665, 5747, 5759, 5777, 5817–5818, 5822, 5824, 5858, 5862, 5864, 5866, 5868, 5914, 5918, 6017–6020, 6022, 6035, 6054, 6064, 6070, 6079–6081, 6084–6087, 6102, 6144, 6173, 6176, 6225–6228, 6231–6235, 6239, 6247, 6253, 6281, 6310, 6316–6317, 6368, 6388–6389, 6391, 6431–6432, 6439, 6444, 6450, 6463–6464, 6466, 6737–6739, 6758, 6771, 6783, 6811, 6971, 6986, 7051, 7081, 7119–7120, 7132, 7147–7148, 7150–7151, 7153–7154, 7156–7157, 7159–7162, 7164, 7166–7167, 7169, 7248–7249, 7261, 7301–7304, 7306, 7313–7314, 7474, 7529, 7564, 7584, 7586, 7687, 7847–7850, 7852–7854, 7913, 7932–7933, 7945, 7961, 7982–7983, 7985, 8002, 8089, 8103, 8106–8109, 8112, 8115, 8137–8140, 8237, 8256–8257, 8385, 8435, 8439–8440, 8454, 8457, 8470–8472, 8475, 8547, 8717–8718, 8798–8799, 8843–8844, 8846, 8849, 8860, 8866–8869, 8871, 8873, 8875–8876, 8993, 9113, 9127, 9130, 9295–9296, 9300, 9361–9364, 9366, 9388, 9400, 9496, 9532–9533, 9546, 9559–9564, 9580–9581, 9589–9590, 9603, 9611–9612, 9629–9630, 9644, 9654, 9670, 9681, 9689–9691, 9693, 9719, 9734, 9745, 9763–9764, 9767, 9785, 9788, 9803, 9817, 9823, 9838, 9855, 9867–9875, 9878–9879, 9881, 9896–9898, 9909, 9912, 10000, 10026, 10033, 10077, 10103–10104, 10147, 10149–10151, 10153, 10224, 10233, 10354, 10418, 10422–10423, 10514–10519, 10614–10617, 10707–10709, 10735, 10768, 10818–10819, 10824–10825, 10842, 10928–10930, 10949, 11157, 11273, 11297, 11320, 11345, 11352–11358, 11360, 11362, 11501, 11549–11550, 11552–11559, 11564–11566, 11568, 11570, 11667–11668, 11686, 11719–11720, 11724
TOTAL438465285% 

Tests Skipped Failures Errors Time
707 12 💤 0 ❌ 0 🔥 33.748s ⏱️

Copy link
Contributor

@sapirshuker sapirshuker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dantavori
Copy link
Contributor Author

force merging to make it available in the next upload.

  1. pre commit passed, no need to wait for lint in gitlab
  2. XSOAR NG run test failed - seems unrelated to the change in the PR (will inform oncall anyway).

@dantavori dantavori merged commit 07da899 into master Feb 21, 2024
23 of 24 checks passed
@dantavori dantavori deleted the csp-fix branch February 21, 2024 09:55
maimorag pushed a commit that referenced this pull request Feb 22, 2024
* fix base client execution metrics

* added test
maimorag pushed a commit that referenced this pull request Feb 28, 2024
* fix base client execution metrics

* added test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants