Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIAC-6413][PANOS] Add CRUD commands for security profile groups #33064

Merged
merged 39 commits into from Mar 13, 2024

Conversation

yaakovpraisler
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Add CRUD commands for security profile groups in Panorama.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Feb 21, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/PAN-OS/Integrations/Panorama
   Panorama.py5834216862%235, 242, 265, 272, 274, 302, 307, 309, 324, 330, 333, 341, 345–346, 350, 352, 355–356, 358, 362–363, 370, 378, 384, 387–388, 392, 409, 443–445, 464, 499, 514, 561, 567, 585, 590, 618–619, 627–628, 685–686, 689, 717–718, 753, 763, 769, 775–776, 778–780, 782, 784–785, 788–789, 791–794, 796, 822–823, 846, 851, 856, 863, 870, 875, 882, 889, 895, 908–909, 913, 918–919, 921–922, 924, 942–944, 952, 959, 965–967, 969, 971–972, 974, 981–983, 992, 994–995, 997–998, 1000, 1007, 1114–1115, 1143, 1158, 1160–1161, 1163–1166, 1169–1170, 1172–1174, 1177–1179, 1181–1182, 1184, 1207, 1243, 1276, 1304, 1346, 1349, 1375, 1398, 1427, 1438, 1456, 1465, 1472, 1479–1480, 1483, 1495, 1508–1510, 1512, 1514, 1530, 1536, 1538, 1542, 1548, 1557, 1564–1565, 1567, 1573, 1580–1581, 1583, 1599, 1607, 1610, 1615, 1638, 1640, 1652, 1654, 1671, 1683, 1730, 1732–1744, 1746, 1795, 1802, 1808, 1815, 1817–1820, 1822, 1838–1842, 1846–1850, 1853, 1855, 1857–1858, 1860, 1862, 1864, 1869, 1876–1877, 1879, 1885, 1892–1893, 1895, 1915, 1917, 1921, 1952, 1954, 1956, 1973, 1983, 1989, 1994, 2004, 2010, 2017–2030, 2032–2033, 2035, 2037, 2041–2050, 2052, 2066, 2074, 2080, 2088–2091, 2093, 2117–2120, 2124, 2132, 2140–2141, 2160–2162, 2167, 2170–2172, 2177, 2192–2196, 2201, 2219–2220, 2222–2230, 2232–2237, 2239–2240, 2242–2245, 2247, 2249, 2254, 2261–2262, 2264, 2270, 2277–2278, 2280, 2299, 2303, 2309–2310, 2312, 2318, 2325, 2331, 2337, 2345–2346, 2348, 2365, 2378, 2384, 2391–2396, 2398, 2400, 2405–2412, 2414, 2428, 2435, 2441, 2449–2452, 2454, 2470–2471, 2473–2475, 2479–2481, 2484, 2486, 2488, 2493, 2500–2501, 2503, 2509, 2516–2517, 2519, 2538, 2542, 2549, 2555, 2561, 2569–2570, 2572, 2586, 2595, 2601, 2608–2610, 2612, 2614, 2618–2621, 2623, 2637, 2644, 2650, 2658–2661, 2663, 2686–2690, 2721, 2724, 2728–2731, 2733, 2735–2736, 2744, 2768, 2771, 2775–2777, 2779, 2788, 2794, 2800, 2808–2809, 2811, 2834, 2843–2844, 2846–2847, 2849, 2856, 2862–2870, 2872–2873, 2880–2884, 2886, 2889, 2904, 2911, 2917, 2925–2928, 2930, 2950–2952, 2990–2991, 3025–3026, 3034, 3079, 3088, 3099–3100, 3102–3104, 3106, 3128, 3130, 3132, 3161–3162, 3234, 3236, 3253–3257, 3259–3264, 3266–3275, 3277–3279, 3283–3285, 3289–3291, 3295–3297, 3301–3303, 3308–3311, 3313–3314, 3319, 3325, 3331, 3339, 3341, 3343, 3388, 3391, 3396, 3403–3408, 3410, 3413–3418, 3422–3427, 3429, 3457, 3465–3466, 3489–3492, 3494–3496, 3498–3501, 3505–3507, 3509–3511, 3513–3516, 3547, 3555, 3561, 3569, 3571–3573, 3575, 3669, 3705–3706, 3721–3723, 3725, 3727, 3729, 3733–3735, 3737–3739, 3741, 3743, 3756, 3782–3786, 3788, 3801–3802, 3808–3810, 3812, 3814–3818, 3829–3849, 3851–3855, 3857, 3866, 3872–3875, 3877–3881, 3883, 3908–3909, 3915–3916, 3924, 3927–3931, 3940, 3942, 3952, 4027, 4031, 4041, 4057, 4061–4062, 4064, 4066, 4102, 4107–4109, 4111, 4113, 4115, 4121, 4135–4145, 4147–4151, 4153, 4158–4165, 4167–4169, 4172–4174, 4177–4178, 4180–4182, 4185–4187, 4190–4191, 4193–4194, 4197–4198, 4200–4201, 4204–4205, 4207, 4235, 4237, 4241, 4243, 4245, 4250, 4313, 4317, 4326, 4328, 4330, 4334, 4339–4340, 4342, 4344, 4346, 4348–4349, 4353, 4365, 4369–4370, 4385, 4418, 4422–4423, 4425–4426, 4428, 4432, 4443, 4445, 4449, 4503, 4507, 4565, 4579, 4585, 4591, 4598–4599, 4601, 4618, 4625, 4628, 4634, 4641–4646, 4648, 4650, 4657–4662, 4664, 4680–4681, 4692–4694, 4697–4699, 4708–4712, 4741, 4749, 4755, 4762–4765, 4767, 4780, 4785–4787, 4790–4791, 4794, 4796–4799, 4801, 4807, 4814–4815, 4817–4820, 4822, 4824, 4841, 4889, 4912–4914, 4916, 4922–4923, 4925, 4931, 4938–4939, 4941, 4943, 4957–4960, 4962, 4964, 4970–4971, 4973, 4979, 4986–4990, 4992, 4994, 4997, 4999–5000, 5002, 5004, 5009, 5023–5025, 5027, 5033–5034, 5036, 5042, 5049–5053, 5055, 5057, 5075–5077, 5079–5081, 5100, 5106–5107, 5109–5114, 5120, 5127–5135, 5137–5138, 5141, 5144–5147, 5149, 5151–5153, 5158, 5187, 5189–5192, 5194, 5196, 5201, 5203–5205, 5207, 5225, 5227, 5229, 5231, 5233, 5237, 5239, 5241, 5243, 5245, 5249, 5251, 5253, 5255, 5257, 5259, 5266, 5268–5271, 5273, 5275, 5280, 5282, 5284–5285, 5295–5296, 5298, 5300–5302, 5304–5306, 5345, 5347–5349, 5351–5355, 5357–5359, 5361–5363, 5365–5367, 5369–5372, 5374–5377, 5379–5381, 5383–5385, 5388, 5391–5393, 5409, 5411, 5414, 5417, 5470, 5482–5483, 5485, 5487, 5528–5529, 5533, 5538, 5578–5580, 5582–5585, 5587, 5589, 5594, 5596–5598, 5600, 5631, 5637, 5639, 5641, 5645, 5655, 5659, 5667, 5673, 5677, 5679, 5683, 5685, 5687, 5693, 5711–5717, 5719, 5721–5724, 5726, 5728, 5733, 5735, 5737–5738, 5748–5749, 5752, 5754–5756, 5758–5760, 5763, 5785, 5787, 5793, 5797, 5801, 5813, 5817, 5823, 5832, 5836, 5840, 5845, 5851–5852, 5854–5857, 5859, 5866–5879, 5915, 5921, 5925, 5929–5936, 5938, 5940, 5944, 5948–5956, 5958–5961, 5963, 5965–5966, 5973–5978, 5980, 5982, 5996, 5999, 6006, 6010, 6012, 6015–6016, 6018–6024, 6026, 6029, 6035–6036, 6038–6041, 6043, 6048–6049, 6055–6056, 6063–6067, 6069–6071, 6073–6076, 6078, 6090, 6097–6098, 6105–6113, 6115, 6131, 6140–6143, 6145–6146, 6153–6161, 6163, 6165, 6167–6169, 6171–6172, 6178–6183, 6185, 6219, 6225, 6230, 6234–6235, 6242–6244, 6246–6247, 6249, 6263, 6270–6271, 6278–6283, 6287, 6318, 6320, 6326–6328, 6330, 6342, 6347–6348, 6350, 6356, 6363–6365, 6367, 6369, 6371, 6375–6376, 6379, 6389, 6394, 6399–6400, 6402, 6408, 6415–6419, 6421, 6424–6432, 6434–6435, 6437–6438, 6441, 6453, 6458–6460, 6466, 6473, 6475, 6477, 6481–6482, 6484, 6494, 6499, 6504–6506, 6511, 6518–6520, 6522, 6526–6534, 6536–6537, 6539–6540, 6542, 6580, 6586–6588, 6593, 6600–6602, 6604, 6606, 6609–6610, 6612, 6622, 6627, 6632–6634, 6639, 6646–6649, 6652–6660, 6662–6663, 6665, 6667, 6669, 6681, 6687–6688, 6690, 6695, 6702–6706, 6708, 6710, 6713–6714, 6716, 6726, 6731, 6736–6738, 6743, 6750–6752, 6754, 6757–6759, 6762–6763, 6765–6766, 6768–6769, 6771, 6782, 6787–6789, 6794, 6799, 6804, 6810, 6817, 6819–6820, 6822–6824, 6831, 6836, 6849, 6854, 6856, 6863–6867, 6869–6871, 6882–6883, 6902, 6905–6920, 6922, 6934–6936, 6958, 6964, 6969–6970, 6986–6988, 6997–7003, 7008–7010, 7015, 7017, 7020–7026, 7031–7033, 7038–7039, 7042–7048, 7053–7055, 7060–7061, 7064–7070, 7075–7077, 7082–7083, 7086–7091, 7096–7097, 7102–7103, 7106–7112, 7117–7119, 7124–7125, 7192, 7197, 7208, 7214, 7216, 7220–7223, 7225, 7227–7235, 7251, 7267, 7270, 7288, 7292–7326, 7338, 7341–7342, 7349, 7356, 7358, 7362–7364, 7366–7367, 7369–7372, 7376, 7378, 7382–7384, 7387, 7432, 7442–7443, 7453, 7460, 7462, 7466–7467, 7469–7470, 7472–7473, 7476, 7490, 7497, 7499, 7503–7506, 7508–7509, 7512, 7526, 7533, 7535, 7539–7544, 7548, 7562, 7569, 7571, 7582, 7585–7590, 7592, 7603–7608, 7610, 7614–7616, 7618–7619, 7623–7624, 7637, 7639–7641, 7644, 7663–7664, 7668–7669, 7674, 7680, 7682, 7687, 7694, 7696, 7700–7702, 7704–7706, 7711–7712, 7715, 7717–7720, 7722, 7724, 7739, 7754, 7756, 7761, 7770, 7772, 7776–7777, 7779, 7786, 7796, 7798, 7802–7803, 7807, 7847, 7853–7856, 7871, 7886, 7888, 7892–7893, 7898, 7915, 7917, 7921–7922, 7927, 7968, 7970, 7974–7975, 7980, 8041, 8043, 8047–8048, 8053, 8070, 8072, 8076–8077, 8082, 8090, 8092, 8096–8097, 8101–8103, 8111–8112, 8120, 8138, 8140, 8146, 8148–8149, 8160, 8178, 8186–8190, 8193, 8197, 8203, 8209, 8215–8217, 8230, 8234, 8236–8238, 8252, 8261, 8269–8271, 8273, 8276–8278, 8282, 8286–8288, 8291, 8295, 8301, 8307–8308, 8311, 8352–8354, 8357, 8368, 8375, 8380, 8398, 8401, 8407–8408, 8418–8419, 8429–8430, 8439–8448, 8452, 8458–8459, 8468–8469, 8477, 8483, 8488, 8492–8495, 8497, 8499, 8503–8504, 8506, 8516, 8550–8551, 8553–8554, 8557, 8559–8564, 8566, 8575–8576, 8589–8590, 8705, 8727, 8744, 8808, 8831–8832, 8840–8841, 8866, 8878, 8892–8894, 8909, 8914–8916, 8945, 8956–8957, 8961, 8975–8976, 8982, 9022–9026, 9032, 9039–9042, 9045–9047, 9049, 9059, 9065–9067, 9069–9070, 9072, 9080, 9082, 9084, 9086, 9124, 9135–9136, 9267, 9596, 9855, 9858, 10033, 10161, 10171, 10216, 10314, 10321–10323, 10327, 10334–10336, 10357, 10364–10366, 10402, 10405–10406, 10508, 10515–10517, 10547–10549, 10551, 10554–10555, 10562, 10579–10582, 10588–10589, 10596, 10614–10617, 10623–10624, 10631, 10842–10844, 10846–10849, 10851, 10853–10854, 10856–10857, 10861–10862, 10872, 10962–10965, 10970, 11010, 11051, 11167, 11169–11171, 11190, 11205–11207, 11213, 11294–11295, 11297, 11309, 11321, 11333, 11347, 11359, 11371, 11385, 11399, 11413, 11428, 11450, 11452, 11477, 11497, 11508, 11518, 11529, 11546, 11564, 11586, 11604, 11620, 11640, 11662, 11677, 11687, 11723, 11737, 11756, 11775, 11811, 11830, 11841–11846, 11848, 11872, 11884–11885, 11887–11888, 11895–11897, 11901–11902, 11904–11905, 11909, 11966, 12034, 12063, 12076, 12096–12099, 12103, 12111–12116, 12122–12127, 12162, 12172, 12175, 12209–12216, 12219, 12221–12223, 12244, 12249–12252, 12262, 12266, 12270, 12297, 12308, 12340, 12387, 12549–12552, 12630, 12669, 12773, 12833, 12844, 12938, 12940, 12962–12965, 12969, 13019, 13082, 13105, 13141, 13187, 13557, 13584–13585, 13627, 13698, 13709, 13843–13846, 13890, 13892–13893, 13896, 13899–13903, 13905, 13907–13910, 14228, 14230–14236, 14238–14239, 14243
TOTAL5834216862% 

Tests Skipped Failures Errors Time
302 0 💤 0 ❌ 0 🔥 4.647s ⏱️

@yaakovpraisler yaakovpraisler marked this pull request as ready for review February 26, 2024 12:33
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far, will re-review after the demo

Packs/PAN-OS/Integrations/Panorama/Panorama.yml Outdated Show resolved Hide resolved
Packs/PAN-OS/Integrations/Panorama/Panorama.yml Outdated Show resolved Hide resolved
Packs/PAN-OS/Integrations/Panorama/README.md Outdated Show resolved Hide resolved
Packs/PAN-OS/Integrations/Panorama/README.md Outdated Show resolved Hide resolved
Packs/PAN-OS/ReleaseNotes/2_1_23.md Outdated Show resolved Hide resolved
@ShirleyDenkberg
Copy link
Contributor

@dantavori @jlevypaloalto Doc review completed.

yaakovpraisler and others added 5 commits March 4, 2024 12:41
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@yaakovpraisler
Copy link
Contributor Author

Test playbooks are failing to run because PAN-OS instance issues.
@dantavori We need a force merge.

@yaakovpraisler yaakovpraisler merged commit 932197d into master Mar 13, 2024
17 checks passed
@yaakovpraisler yaakovpraisler deleted the panos-CIAC-6413 branch March 13, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants