Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ciac 8941/enhancement/cortex xdr flexible close reason mappings mirroring #33140

Conversation

barryyosi-panw
Copy link
Contributor

@barryyosi-panw barryyosi-panw commented Feb 29, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Enhancing Cortex XDR IR integration with flexible close-reason mappings for mirrored incidents.

Must have

  • Tests
  • Documentation

barryyosi-panw and others added 14 commits February 29, 2024 12:50
…-Flexible-Close-Reason-Mappings-Mirroring' into CIAC-8941/Enhancement/Cortex-XDR-Flexible-Close-Reason-Mappings-Mirroring
…-Flexible-Close-Reason-Mappings-Mirroring' into CIAC-8941/Enhancement/Cortex-XDR-Flexible-Close-Reason-Mappings-Mirroring
…-Flexible-Close-Reason-Mappings-Mirroring' into CIAC-8941/Enhancement/Cortex-XDR-Flexible-Close-Reason-Mappings-Mirroring
@dansterenson dansterenson removed their request for review March 3, 2024 09:55
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Core pack version was bumped to 3.0.22.
  • CortexXDR pack version was bumped to 6.1.19.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

">> Resolving comma-separated input mapping: {raw_text}".format(raw_text=raw_text))

mapping_dict = {} # type: Dict[str, str]
# If a proper mapping was not provided, return an empty dict.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment is redundant

key_value_pairs = raw_text.split(',')

for pair in key_value_pairs:
# Trimming trailing whitespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment is redundant

Copy link
Contributor

@thefrieddan1 thefrieddan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice !

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CortexXDR pack version was bumped to 6.1.20.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@barryyosi-panw barryyosi-panw merged commit 1e19385 into master Mar 6, 2024
17 checks passed
@barryyosi-panw barryyosi-panw deleted the CIAC-8941/Enhancement/Cortex-XDR-Flexible-Close-Reason-Mappings-Mirroring branch March 6, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants