Cybereason v2.1.17 #33336
Cybereason v2.1.17 #33336
Conversation
Cybereason command addition
|
|
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/metron-labs_cybereason-v2.1.17
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @jbabazadeh will know the proposed changes are ready to be reviewed. |
content-bot
added
Partner-Approved
Contribution Form Filled
…ontent into cybereason-v2.1.17
There was a problem hiding this comment.
Hi @shabina-metron ,
Thank you for your contribution!
Good work :)
Please see my comment
| malop_output = { | ||
| 'GUID': guid, | ||
| 'Link': link, | ||
| 'CreationTime': creation_time, | ||
| 'LastUpdateTime': malop_last_update_time, | ||
| 'Status': management_status, | ||
| 'InvolvedHash': involved_hashes | ||
| } | ||
| outputs.append(malop_output) |
There was a problem hiding this comment.
I think this lines need to be inside the for loop?
There was a problem hiding this comment.
Yes, you are correct. We have modified the code and pushed it again. Thanks.
| else: | ||
| link = SERVER + '/#/detection-malop/' + guid | ||
|
|
||
| outputs = [] |
There was a problem hiding this comment.
please move the outputs = [] outside the for loop
There was a problem hiding this comment.
Yes, I have updated the code.
There was a problem hiding this comment.
Hi @shabina-metron , the code looks good!
We're ready for a demo. Please check this page, and let me know when you're available for one over DFIR.
|
Hi, Thanks for your response. I'll reach out to you on DFIR regarding Demo. Thanks |
jbabazadeh
added
the
ready-for-instance-test
|
For the Reviewer: Successfully created a pipeline in Gitlab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/905568 |
|
For the Reviewer: Trigger build request has been accepted for this contribution PR. |
|
For the Reviewer: Successfully created a pipeline in GitLab with url: {url} |
content-bot
removed
the
ready-for-instance-test
jbabazadeh
merged commit 2f99da5
into
demisto:contrib/metron-labs_cybereason-v2.1.17
|
Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days. |
* Added new commands to get process attack tree url and single malop details * Added new commands * Added unit test * Updated Version and release notes * Updated Readme file * updated docker image version * Fixed PR Comments * fix github checks failure * fix github checks failure * Added range in query * fix demisto PR comments * fix demisto PR comments --------- Co-authored-by: shabina-metron <108517842+shabina-metron@users.noreply.github.com> Co-authored-by: sourabh-metron <110430849+sourabh-metron@users.noreply.github.com> Co-authored-by: JudithB <132264628+jbabazadeh@users.noreply.github.com>
|
Hi @shabina-metron |
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have