Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServiceNow v2] Fixed issue in mirroring #33341

Merged
merged 14 commits into from Mar 18, 2024

Conversation

mmhw
Copy link
Contributor

@mmhw mmhw commented Mar 13, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Fixed an issue where the get-remote-data (mirroring) command was not returning the display values for all fields when the Use display values option was enabled.

Must have

  • Tests
  • Documentation

@mmhw mmhw requested a review from DeanArbel March 13, 2024 13:21
@mmhw mmhw self-assigned this Mar 13, 2024
Copy link
Contributor

@bziser bziser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bziser
Copy link
Contributor

bziser commented Mar 14, 2024

@mmhw
please add a test which simulates the bug

@mmhw mmhw requested a review from bziser March 17, 2024 12:29
Copy link
Contributor

@bziser bziser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
It would be helpful if you could provide screenshots before and after the changes were made to the mapper
And update the description of the pr

@mmhw mmhw merged commit e7db9bc into master Mar 18, 2024
21 checks passed
@mmhw mmhw deleted the MW/ServiceNow_v2/Fix_issue_in_mirroring branch March 18, 2024 09:02
@mmhw
Copy link
Contributor Author

mmhw commented Mar 18, 2024

Mapper changes
Before:
image

After:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants