Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace Contribution] Abnormal Security - Content Pack Update #33462

Merged

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Warning
The changes in the contributed files were not made on the most updated pack versions

Item Name Contribution Pack Version Latest Pack Version
Abnormal Security 2.2.4 2.2.5

For the Reviewer:

  1. Compare the code of this PR with the latest version of the pack. Make sure you understand the changes the contributor intended to contribute, and solve the conflicts accordingly.
  2. In case improvements are needed, instruct the contributor to edit the code through the GitHub Codespaces and Not through the XSOAR UI.

For the Contributor:
@vipulkaneriya
In case you are requested by your reviewer to improve the code or to make changes, submit them through the GitHub Codespaces and Not through the XSOAR UI.

To use the GitHub Codespaces, do the following:

  1. Click the 'Code' button in the right upper corner of this PR.
  2. Click 'Create codespace on Transformers'.
  3. Click 'Authorize and continue'.
  4. Wait until your Codespace environment is generated. When it is, you can edit your code.
  5. Commit and push your changes to the head branch of the PR.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@vipulkaneriya

Notes

We had a challenge searching Threat log and Abuse campaign with limited search filter available for "abnormal-security-list-abuse-mailbox-campaigns" and "abnormal-security-list-threats". I reviewed the Abnormal Security API documentation and found out that we can narrow down list of Threat log and Abuse campaign by adding more search parameters. I added list result by sender, recipient, subject etc and hope your other customer will also benefits from this.

I request you to review other "list" command and add more search parameters.

refer:
https://app.swaggerhub.com/apis/abnormal-security/abx/1.4.2#/Abuse%20Mailbox/get_abusecampaigns
https://app.swaggerhub.com/apis/abnormal-security/abx/1.4.2#/Threats/get_threats

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

…32959)

* "contribution update to pack "Abnormal Security""

* Update Packs/AbnormalSecurity/ReleaseNotes/2_3_0.md

* Rename 2_3_0.md to 2_2_7.md

---------

Co-authored-by: JudithB <132264628+jbabazadeh@users.noreply.github.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! post-demo pending-contributor The PR is pending the response of its creator Partner Support Level Indicates that the contribution is for Partner supported pack Internal PR Partner-Approved TIM Review labels Mar 21, 2024
@jbabazadeh jbabazadeh merged commit 3d1229c into master Mar 25, 2024
17 checks passed
@jbabazadeh jbabazadeh deleted the contrib/xsoar-contrib_vipulkaneriya-contrib-AbnormalSecurity branch March 25, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Thank you! Contributions are always welcome! docs-approved Internal PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner-Approved pending-contributor The PR is pending the response of its creator post-demo TIM Review
Projects
None yet
3 participants