Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crowd strike indicator feed - Get correct threat actor names #33607

Merged
merged 26 commits into from Apr 7, 2024

Conversation

tcarmeli1
Copy link
Contributor

@tcarmeli1 tcarmeli1 commented Mar 27, 2024

Status

  • Ready

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9250

Description

At the moment the CS Indicator feed has the threat actor names come back as a single string with no spaces. This breaks the relationships within XSOAR. Using another API call we get the correct threat actor names from CS saving them in the context as well for future use to minimize calls.

@Ni-Knight Ni-Knight changed the title Crowd strike bug fix Crowd strike indicator feed - Get correct threat actor names Apr 3, 2024
@Ni-Knight
Copy link
Contributor

QA'd the integration, looks good on the GUI side, we need to somehow test the cache.

image

Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Copy link

github-actions bot commented Apr 4, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/FeedCrowdstrikeFalconIntel/Integrations/CrowdStrikeIndicatorFeed
   CrowdStrikeIndicatorFeed.py2253684%139, 165, 167, 170, 175, 179, 195–197, 201–205, 272–273, 299–300, 321, 458, 463–465, 503, 509–512, 514, 577–578, 581, 584, 587, 590–591
TOTAL2253684% 

Tests Skipped Failures Errors Time
22 0 💤 0 ❌ 0 🔥 2.214s ⏱️

@tcarmeli1 tcarmeli1 merged commit 7413cb7 into master Apr 7, 2024
16 of 17 checks passed
@tcarmeli1 tcarmeli1 deleted the crowd-strike-enhance branch April 7, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants