New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crowd strike indicator feed - Get correct threat actor names #33607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ni-Knight
changed the title
Crowd strike bug fix
Crowd strike indicator feed - Get correct threat actor names
Apr 3, 2024
Ni-Knight
reviewed
Apr 3, 2024
Ni-Knight
approved these changes
Apr 3, 2024
jbabazadeh
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
FIX REALSE NOTE Co-authored-by: Dror Avrahami <davrahami@paloaltonetworks.com>
Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9250
Description
At the moment the CS Indicator feed has the threat actor names come back as a single string with no spaces. This breaks the relationships within XSOAR. Using another API call we get the correct threat actor names from CS saving them in the context as well for future use to minimize calls.