Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PreprocessEmail] Fix an issue in parsing images #33651

Merged

Conversation

mmhw
Copy link
Contributor

@mmhw mmhw commented Mar 31, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Fixed an issue in Fetch incident with inline image attachments in PreprocessEmail script by adding description field to attachments to distinguish file attachments from inline images.

Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests that use this Enum.
@anara123 Please review as well

@DeanArbel DeanArbel requested a review from anara123 April 1, 2024 13:36
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • MicrosoftExchangeOnline pack version was bumped to 1.2.47.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

Copy link

github-actions bot commented Apr 4, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Base/Scripts/CommonServerPython
   CommonServerPython.py442766984%167–170, 181, 183, 419, 461, 557, 583–587, 612, 627, 767–768, 777, 818–819, 837, 867–871, 875–877, 919, 1006–1014, 1058–1063, 1097–1099, 1229–1233, 1236–1237, 1239–1241, 1255–1257, 1259, 1325, 1338, 1351, 1359–1361, 1363, 1376, 1384, 1471–1472, 1527, 1549–1550, 1553, 1559, 1561, 1563, 1657, 1702, 1774–1775, 1779–1780, 1819–1820, 1834–1839, 1841, 1909, 1992, 1994, 2014, 2044, 2048, 2090, 2269, 2293, 2332–2333, 2413–2414, 2416, 2429–2436, 2438, 2515–2517, 2531, 2544, 2575, 2581–2585, 2587–2589, 2591, 2595–2596, 2598, 2611–2617, 2621, 2625–2627, 2633–2634, 2646, 2674, 2677, 2682, 2702, 2708, 2710, 2712, 2732, 2735, 2747, 2793–2801, 2803, 2862, 2884, 2904, 2962, 2974–2975, 3087, 3089, 3264, 3274, 3280, 3289, 3295, 3309, 3365, 3380, 3382, 3413–3418, 3421, 3472–3473, 3476, 3642–3643, 3646, 3753, 3756, 3981, 3984, 3987, 3990, 3995, 4004, 4030, 4036, 4039, 4048, 4050, 4166–4167, 4191, 4193, 4212, 4215, 4218, 4286, 4307, 4309, 4445, 4463, 4475, 4511, 4513, 4687–4688, 4766, 4768, 4793, 4808–4824, 4827, 4831–4832, 4834–4835, 4837–4838, 4840–4841, 4843–4844, 4846–4847, 4849–4850, 4852–4853, 4855–4856, 4858–4859, 4861–4862, 4864–4865, 4867–4868, 4870, 4872–4873, 4875–4878, 4880–4882, 4884, 4886, 4890, 4961, 4993, 4999, 5001, 5039, 5044–5045, 5050, 5054–5055, 5057, 5139, 5145, 5237, 5258, 5261–5266, 5274–5280, 5282–5283, 5328, 5341, 5436–5439, 5444, 5447, 5450, 5484, 5487, 5531, 5533, 5535, 5630, 5681, 5763, 5775, 5793, 5833–5834, 5838, 5840, 5874, 5878, 5880, 5882, 5884, 5930, 5934, 6033–6036, 6038, 6051, 6070, 6080, 6086, 6095–6097, 6100–6103, 6118, 6160, 6189, 6192, 6241–6244, 6247–6251, 6255, 6263, 6269, 6297, 6326, 6332–6333, 6384, 6404–6405, 6407, 6447–6448, 6455, 6460, 6466, 6479–6480, 6482, 6753–6755, 6774, 6787, 6799, 6827, 6987, 7002, 7067, 7097, 7135–7136, 7148, 7163–7164, 7166–7167, 7169–7170, 7172–7173, 7175–7178, 7180, 7182–7183, 7185, 7264–7265, 7277, 7317–7320, 7322, 7329–7330, 7490, 7545, 7580, 7600, 7602, 7703, 7863–7866, 7868–7870, 7929, 7948–7949, 7961, 7977, 7998–7999, 8001, 8018, 8105, 8119, 8122–8125, 8128, 8131, 8153–8156, 8253, 8272–8273, 8401, 8486, 8490–8491, 8505, 8508, 8521–8523, 8526, 8598, 8768–8769, 8849–8850, 8894–8895, 8897, 8900, 8911, 8917–8920, 8922, 8924, 8926–8927, 9044, 9169, 9183, 9186, 9351–9352, 9356, 9417–9420, 9422, 9444, 9456, 9552, 9588–9589, 9602, 9615–9620, 9636–9637, 9645–9646, 9659, 9667–9668, 9685–9686, 9700, 9710, 9726, 9737, 9745–9747, 9749, 9775, 9790, 9801, 9819–9820, 9823, 9841, 9844, 9859, 9873, 9879, 9894, 9911, 9923–9931, 9934–9935, 9937, 9952–9954, 9965, 9968, 10056, 10082, 10089, 10133, 10159–10160, 10203, 10205–10207, 10209, 10280, 10289, 10410, 10474, 10478–10479, 10570–10575, 10670–10673, 10763–10765, 10791, 10824, 10874–10875, 10880–10881, 10898, 10984–10986, 11005, 11213, 11329, 11353, 11376, 11401, 11408–11414, 11416, 11418, 11561, 11610–11611, 11613–11620, 11625–11627, 11629, 11631, 11732–11733, 11751, 11784–11785, 11789, 11829, 11832, 11834–11835, 11837, 11839, 11841, 11843–11846, 11848, 11850–11851, 11855–11857
Packs/EmailCommunication/Scripts/PreprocessEmail
   PreprocessEmail.py2186172%23, 40–41, 44, 84, 107–108, 150, 152–154, 157–159, 161–164, 166–168, 170, 182–185, 226, 236–240, 255–258, 284, 289–291, 301–308, 340, 357, 360, 363, 378–381, 448–449, 451–452, 455
Packs/MicrosoftExchangeOnPremise/Integrations/EWSv2
   EWSv2.py2872391%1015, 1030, 1052, 1057–1058, 1069, 1074, 1450–1459, 1819–1820, 1828, 1832, 1836, 2361
Packs/MicrosoftExchangeOnline/Integrations/EWSO365
   EWSO365.py4058678%139–140, 150–151, 248–250, 282–285, 325–326, 328–329, 331, 365–367, 402, 407–410, 435, 454–455, 462–463, 475, 500–504, 512–513, 594–596, 608–611, 613, 631, 633, 697, 708, 883–884, 888, 923–926, 1446, 1605–1607, 1658–1659, 1779, 1825, 2066, 2072–2073, 2354–2356, 2359, 2367, 2404–2413, 2432, 2661–2662, 2685
TOTAL533783984% 

Tests Skipped Failures Errors Time
48 0 💤 0 ❌ 0 🔥 2.415s ⏱️

Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Base pack version was bumped to 1.33.50.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • MicrosoftExchangeOnline pack version was bumped to 1.3.3.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@mmhw mmhw self-assigned this Apr 7, 2024
@mmhw mmhw added the ForceMerge label Apr 7, 2024
@mmhw
Copy link
Contributor Author

mmhw commented Apr 7, 2024

Reason for force merge:
2 TPB failed on NG.

@DeanArbel DeanArbel merged commit 1b1d582 into master Apr 7, 2024
19 of 21 checks passed
@DeanArbel DeanArbel deleted the MW/XSUP-33708/PreprocessEmail/Fix_issue_in_display_images branch April 7, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants