Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reco.py: change validate api key endpoint #33659

Merged
merged 3 commits into from Apr 3, 2024
Merged

reco.py: change validate api key endpoint #33659

merged 3 commits into from Apr 3, 2024

Conversation

GalNakash-RecoLabs
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Mar 31, 2024
@content-bot content-bot changed the base branch from master to contrib/RecoLabs_reco-validate-key March 31, 2024 13:42
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @maimorag will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Mar 31, 2024
@GalNakash-RecoLabs
reco.py: change validate api key endpoint
9aa1d61 
Signed-off-by: Gal Nakash <gal@recolabs.ai>
maimorag
maimorag reviewed Apr 1, 2024
View reviewed changes
Copy link
Contributor

@maimorag maimorag left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GalNakash-RecoLabs,
Thank you for your contribution!
Good work :)

The docker image tag is not the latest numeric tag, please update it.
To update the docker image run:
demisto-sdk format -ud -i Packs/Reco/Integrations/Reco/Reco.yml

Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again :)

@GalNakash-RecoLabs @maimorag
Update Packs/Reco/ReleaseNotes/1_2_1.md
4c6a54a 
Co-authored-by: Mai Morag <81917647+maimorag@users.noreply.github.com>
@MLainer1 MLainer1 removed their request for review April 1, 2024 11:03
@maimorag maimorag added Partner-Approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed Partner-Approved labels Apr 1, 2024
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/927059

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Apr 1, 2024
@maimorag
Copy link
Contributor

maimorag commented Apr 2, 2024

Hi @GalNakash-RecoLabs ,
the code looks good!

We're ready for a demo. Please check this page, and let me know when you're available for one over DFIR.
You can also send me a recording of a demo.

@GalNakash-RecoLabs
Copy link
Contributor Author

GalNakash-RecoLabs commented Apr 2, 2024 via email

maimorag
maimorag reviewed Apr 3, 2024
View reviewed changes
Packs/Reco/Integrations/Reco/Reco_test.py
@@ -420,7 +420,7 @@ def get_mock_assets() -> list[dict[str, Any]]:
def test_test_module_success(requests_mock, reco_client: RecoClient) -> None:
mock_response = {"dataSources": {"tablesMetadata": [{"name": "table1"}]}}
requests_mock.get(
f"{DUMMY_RECO_API_DNS_NAME}/data-sources", json=mock_response
f"{DUMMY_RECO_API_DNS_NAME}/policy-subsystem/alert-inbox?limit=1", json=mock_response
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Please notice you have an assertion error in the unit test test_test_module_success
AssertionError: assert 'Invalid token' == 'ok'

@GalNakash-RecoLabs
reco: update yml
5d2423b 
Signed-off-by: Gal Nakash <gal@recolabs.ai>
@maimorag maimorag added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Apr 3, 2024
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/932284

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Apr 3, 2024
@maimorag maimorag merged commit d5762b1 into demisto:contrib/RecoLabs_reco-validate-key Apr 3, 2024
24 of 26 checks passed
@content-bot content-bot mentioned this pull request Apr 3, 2024
Merged
5 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

maimorag added a commit that referenced this pull request Apr 4, 2024
@content-bot @GalNakash-RecoLabs @maimorag
reco.py: change validate api key endpoint (#33659) (#33744)
1e8d2de 
* reco.py: change validate api key endpoint



* Update Packs/Reco/ReleaseNotes/1_2_1.md



* reco: update yml



---------

Signed-off-by: Gal Nakash <gal@recolabs.ai>
Co-authored-by: GalNakash-RecoLabs <71227802+GalNakash-RecoLabs@users.noreply.github.com>
Co-authored-by: Mai Morag <81917647+maimorag@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maimorag maimorag maimorag approved these changes

Assignees

@maimorag maimorag

@edik24 edik24

Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved TIM Review
Projects
None yet
Milestone
No milestone
4 participants
@GalNakash-RecoLabs @content-bot @maimorag @edik24