Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServiceNow] Support mirroring notes created before fetch #33761

Merged
merged 12 commits into from Apr 7, 2024

Conversation

yaakovpraisler
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Support mirroring notes created before the incident was fetched.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Apr 4, 2024

Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some minor notes
add docstrings to the methods to explain the need
and let's schedule a short demo with anar

Packs/ServiceNow/Integrations/ServiceNowv2/ServiceNowv2.py Outdated Show resolved Hide resolved
Packs/ServiceNow/Integrations/ServiceNowv2/ServiceNowv2.py Outdated Show resolved Hide resolved
Packs/ServiceNow/ReleaseNotes/2_5_65.md Outdated Show resolved Hide resolved
@yaakovpraisler yaakovpraisler merged commit a6ec34b into master Apr 7, 2024
17 checks passed
@yaakovpraisler yaakovpraisler deleted the SNOW-CIAC-9955 branch April 7, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants