Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tanium - fix proxy handling #33784

Merged
merged 6 commits into from Apr 10, 2024
Merged

Tanium - fix proxy handling #33784

merged 6 commits into from Apr 10, 2024

Conversation

yucohen
Copy link
Contributor

@yucohen yucohen commented Apr 7, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-35421

Description

The proxy handle was before the client creation which overided the proxy settings

Copy link

github-actions bot commented Apr 7, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Tanium/Integrations/Tanium_v2
   Tanium_v2.py70247532%36–37, 40–45, 48–49, 51, 54, 72, 77, 86, 93–94, 96–98, 100–103, 107, 109, 154–157, 159, 183, 194–195, 203, 208, 210, 222, 232–236, 247, 249, 254, 270, 273, 281, 285, 288, 296, 303–304, 323, 341–344, 346–350, 352–356, 362–363, 366, 375–377, 379–383, 386, 403–407, 409–413, 434–435, 439–441, 451–452, 464, 483–487, 489–492, 494, 497, 518–522, 524, 527, 535, 546, 552, 554–555, 557, 559, 566–568, 572–573, 575–578, 580–583, 587–595, 597–600, 602–603, 605–606, 608–611, 615–617, 619–620, 622–623, 625–626, 628–631, 635–637, 640–641, 643–645, 647–650, 654–662, 664–665, 667–668, 670–671, 673–675, 679–680, 682, 684–687, 689–692, 696–697, 699–701, 703–704, 706–709, 713–716, 718–721, 730, 732, 734–736, 739–743, 747–750, 752–753, 755–758, 762–770, 772–773, 775–778, 782–785, 787, 789–792, 795–799, 803–804, 806, 808–810, 812–815, 819–826, 828, 833–834, 836–839, 843–851, 853, 858–859, 861–864, 868–871, 873–876, 880–881, 883, 885–887, 889–892, 896–898, 900–902, 904–907, 911–919, 921–922, 924–927, 931–932, 934, 936–938, 940–943, 947–948, 950–953, 955–958, 962–964, 966–967, 969, 971–972, 974–977, 979–982, 984–985, 987–989, 991–994, 998–999, 1001, 1003–1005, 1007–1010, 1014–1022, 1024–1026, 1028–1031, 1035–1036, 1038, 1040–1041, 1043–1046, 1050–1056, 1082–1083, 1097–1100, 1102, 1104, 1106–1108, 1110–1113, 1115, 1146–1149, 1151–1153, 1157
TOTAL70247532% 

Tests Skipped Failures Errors Time
13 0 💤 0 ❌ 0 🔥 1.226s ⏱️

@yucohen yucohen marked this pull request as ready for review April 10, 2024 07:56
@yucohen yucohen requested a review from DeanArbel April 10, 2024 07:56
Copy link
Contributor

@omerKarkKatz omerKarkKatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!

@yucohen yucohen merged commit 6d8d3c1 into master Apr 10, 2024
20 checks passed
@yucohen yucohen deleted the XSUP-35421_fix_porxy branch April 10, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants