Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crowdstrike: added argument polling_timeout to cs-falcon-rtr-retrieve-file command #33849

Merged
merged 5 commits into from Apr 10, 2024

Conversation

moishce
Copy link
Contributor

@moishce moishce commented Apr 9, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Added a new argument polling_timeout to the cs-falcon-rtr-retrieve-file command to set the polling timeout.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Apr 9, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon
   CrowdStrikeFalcon.py277975472%359–360, 368, 414, 418, 430, 464–465, 467–468, 486, 593–595, 610, 613, 641–650, 671, 746, 784–785, 787, 790–792, 840, 870, 929–930, 932, 937, 940–941, 956–958, 963, 966–967, 982–983, 985, 990, 993–994, 1022, 1024, 1029–1030, 1040, 1042, 1047–1048, 1158, 1275, 1277, 1304, 1306, 1323–1324, 1327–1332, 1334–1335, 1356, 1360, 1395, 1399, 1490, 1502–1503, 1505–1506, 1509, 1511, 1515–1516, 1552, 1561, 1566, 1595, 1597, 1625, 1629, 1661, 1663, 1793, 1799, 1810–1812, 1821–1825, 1838, 1841–1848, 1850, 1852, 1865, 1869, 1878, 1881–1882, 1885, 1894, 1897–1898, 1901, 1917, 1949, 1955–1958, 1961, 1965, 2017–2018, 2020, 2024, 2027, 2030, 2034–2035, 2038, 2053, 2209–2213, 2218, 2221, 2224–2225, 2228–2230, 2232, 2241, 2292–2303, 2337–2341, 2426, 2431, 2470–2473, 2476, 2479, 2481–2482, 2525–2527, 2530–2532, 2534, 2555, 2646, 2671–2672, 2729–2730, 2778, 2887, 3070–3071, 3256, 3360–3361, 3363, 3401–3406, 3456–3459, 3528, 3535, 3573, 3662, 3677, 3695, 3708, 3729–3732, 3745–3749, 3751–3752, 3754–3755, 3763–3771, 3778, 3822, 3828, 3856–3864, 3866–3867, 3875–3888, 3890–3892, 3894–3896, 3898–3900, 3902, 3904, 3906, 3918–3926, 3928–3938, 3946–3949, 3957–3960, 3996–3999, 4018–4023, 4025–4026, 4028–4035, 4045–4046, 4049, 4265–4267, 4274, 4296–4299, 4311, 4342–4345, 4361, 4393–4396, 4416–4417, 4427, 4440–4441, 4443, 4452–4455, 4496–4497, 4515–4518, 4563–4566, 4598, 4603–4604, 4629, 4633, 4645, 4647–4648, 4685–4686, 4692, 4713–4714, 4730–4731, 4746, 4760, 4763–4764, 4772, 4775–4776, 4787, 4791, 4830–4832, 4840–4842, 4844, 4871–4880, 4911, 4978–4981, 4984–4985, 4989–4992, 4995–4996, 5005–5006, 5008, 5010, 5012, 5014–5016, 5020, 5034–5038, 5103–5105, 5107, 5110, 5112, 5115, 5117–5119, 5121, 5123–5124, 5128–5132, 5137, 5139–5140, 5144–5145, 5147–5151, 5155, 5215, 5318, 5660, 5671, 5742, 5744, 5753, 5759, 5826, 5833, 5838, 5840, 5850, 5856, 5861, 5863–5864, 5866–5868, 5870, 5878, 5896, 5905, 5911, 5929, 5937, 5942, 5944–5945, 5947–5949, 5951, 5959, 5989, 5995, 6000, 6002, 6011, 6017, 6022, 6024–6025, 6027–6029, 6031, 6039, 6093, 6095–6096, 6098–6099, 6101, 6145–6146, 6148–6149, 6156, 6158, 6163, 6242, 6271–6272, 6280–6282, 6286, 6350, 6402, 6455, 6576, 6650–6651, 6653, 6655, 6672–6674, 6676–6681, 6683–6746, 6748–6759, 6766–6779, 6781–6782, 6784–6785, 6793–6794, 6796–6797, 6799–6800, 6802–6803, 6805–6809, 6813–6817, 6821–6822, 6824–6829, 6831–6834, 6836–6885, 6887–6902, 6904, 6906–6907
TOTAL277975472% 

Tests Skipped Failures Errors Time
300 0 💤 0 ❌ 0 🔥 6.344s ⏱️

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CrowdStrikeFalcon pack version was bumped to 1.13.5.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain in the support ticket the difference between what the customer complained about and the feature you added, explain that it is A NEW FEATURE that you have now added.

@moishce moishce merged commit 52b9ce9 into master Apr 10, 2024
17 checks passed
@moishce moishce deleted the CrowdStrikeFalcon-polling-timeout branch April 10, 2024 07:45
RosenbergYehuda added a commit that referenced this pull request Apr 10, 2024
…-file command (#33849)

* Added argument polling_timeout

* Bump pack from version CrowdStrikeFalcon to 1.13.5.

* Updated Dockerimage

---------

Co-authored-by: Content Bot <bot@demisto.com>
RosenbergYehuda added a commit that referenced this pull request Apr 10, 2024
* ews workaround

* fix find folders

* access directly

* Update Packs/MicrosoftExchangeOnline/Integrations/EWSO365/EWSO365.py

* Update Packs/MicrosoftExchangeOnline/Integrations/EWSO365/EWSO365.py

access directly

* fixed search

* fixed tests

* added rn

* Update Packs/MicrosoftExchangeOnline/ReleaseNotes/1_3_0.md

Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com>

* same as master

* revert parts of https://github.com/demisto/content/pull/33754/files

* revert part of https://github.com/demisto/content/pull/33771/files

* revert part of the changes in https://github.com/demisto/content/pull/33754/files

* update docker

* RN

* pre commit

* ignore native

* fix

* pre commit

* cr

* cr

* fix from Shirley

* new image

* RN

* new image

* fix RN

* Crowdstrike: added argument polling_timeout to cs-falcon-rtr-retrieve-file command (#33849)

* Added argument polling_timeout

* Bump pack from version CrowdStrikeFalcon to 1.13.5.

* Updated Dockerimage

---------

Co-authored-by: Content Bot <bot@demisto.com>

---------

Co-authored-by: Dan Tavori <dtavori@paloaltonetworks.com>
Co-authored-by: Judah Schwartz <juschwartz@paloaltonetworks.com>
Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com>
Co-authored-by: sbenyakir <shahaf.benyakir@demisto.com>
Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants