Gitlab v2.2.22 - Argument Description Change #33855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated Release Notes and added CONTRIBUTORS.json * Aligned CommandResults output. * Updated GitLabv2.yml GetFile Argument Description * v.2.2.22 * Encoded file_path --------- Co-authored-by: JudithB <132264628+jbabazadeh@users.noreply.github.com> Co-authored-by: Anas Yousef <44998563+anas-yousef@users.noreply.github.com>
content-bot
added
Contribution
anas-yousef
removed
the
pending-contributor
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||
anas-yousef
reviewed
Apr 14, 2024
There was a problem hiding this comment.
@maimorag
I updated to use CheckFileCommand, since running the task using ./CheckFileCommand returns an error.
|
@JasBeilin Concerning the encoding mechanism, I tried the following file_path arguments, and they all worked:
These should cover our cases, I also added tests for them, so should be good. |
maimorag
reviewed
Apr 16, 2024
There was a problem hiding this comment.
@anas-yousef looks great,
Can you update the function file_create_command (line 979) as well to keep in the same format?
Thanks :)
…rib/mohlcyber_Gitlab
JasBeilin
approved these changes
Apr 17, 2024
barryyosi-panw
pushed a commit
that referenced
this pull request
Apr 24, 2024
* Gitlab v2.2.22 - Argument Description Change (#33637) * Updated Release Notes and added CONTRIBUTORS.json * Aligned CommandResults output. * Updated GitLabv2.yml GetFile Argument Description * v.2.2.22 * Encoded file_path --------- Co-authored-by: JudithB <132264628+jbabazadeh@users.noreply.github.com> Co-authored-by: Anas Yousef <44998563+anas-yousef@users.noreply.github.com> * Fixed TPB * Writing unit tests * Added support for not encoding already encoded file paths * pre-commit * Fixed comment * Added commit * Fixed comments * Added to file create command * CR fixes --------- Co-authored-by: Martin Ohl <Martin.Ohl@ohl-net.eu> Co-authored-by: JudithB <132264628+jbabazadeh@users.noreply.github.com> Co-authored-by: Anas Yousef <44998563+anas-yousef@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@mohlcyber
Status
Related Issues
Argument Description for gitlab-file-get and gitlab-raw-file-get misleading
Description
Must have