Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing xdr_close_reason_resolution #33867

Merged

Conversation

barryyosi-panw
Copy link
Contributor

@barryyosi-panw barryyosi-panw commented Apr 10, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Fixed an issue in XDR IR <-> XSOAR mirroring, where non-default XSOAR close-reasons were not resolved properly.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Apr 10, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ApiModules/Scripts/CoreIRApiModule
   CoreIRApiModule.py161225784%183, 186, 191, 205, 223–226, 230, 237, 244, 251, 258, 280, 326, 331, 374, 389, 400, 412, 472–473, 479–484, 509, 515, 521, 533, 543, 549, 568, 580, 586, 592, 604, 614, 620, 656, 691, 720, 736, 738, 846, 876, 879, 889, 958, 964, 984, 990, 992, 1019, 1035, 1221, 1245, 1251, 1264, 1266–1267, 1269, 1275–1276, 1282–1283, 1289, 1296–1297, 1330, 1332, 1378, 1385, 1392, 1398, 1404, 1411, 1418, 1428, 1458, 1534–1537, 1539–1545, 1550, 1555–1558, 1560–1561, 1563–1564, 1566–1570, 1572–1573, 1575, 1579, 1586–1587, 1602–1603, 1619, 1624, 1632, 1680–1682, 1686, 1689, 1713, 1798, 1804, 1808, 1812, 1817, 1823, 1835–1836, 1842, 1847, 1853, 1856–1858, 1890, 1893–1896, 2010, 2083, 2089, 2093, 2097, 2100, 2514, 2525, 2528–2530, 2534–2537, 2541–2542, 2548, 2550–2554, 2558, 2564, 2566–2567, 2569, 2573–2576, 2578, 2585, 2587–2588, 2591–2595, 2598, 2600, 2602, 2604–2607, 2611–2612, 2614–2619, 2621, 2652, 2827–2830, 2834–2835, 2846, 2946, 2975, 2977, 2979, 3219–3220, 3312–3314, 3322, 3343, 3457–3460, 3546, 3554, 3558–3559, 3617–3619, 3625, 3664, 3678, 3685, 3692, 3734, 3741, 3748, 3755, 3762, 3966, 4002–4005, 4007–4009, 4112, 4146, 4152, 4159, 4161, 4168, 4170, 4188, 4211
Packs/Core/Integrations/CortexCoreIR
   CortexCoreIR.py551278%36–39, 41, 44, 47, 54, 58, 61, 63, 107
Packs/CortexXDR/Integrations/CortexXDRIR
   CortexXDRIR.py5678185%59, 67, 71–73, 148–152, 154, 157, 160, 164, 202, 232–236, 238, 245–248, 259, 262, 265, 271, 274, 300, 305, 313, 315, 318–322, 324, 393, 407–412, 444, 505, 515, 574, 577, 603, 610, 612, 689–690, 692, 745, 925–927, 930, 933, 938, 992–993, 1044, 1053, 1055–1057, 1060, 1063–1064, 1101–1104, 1136, 1153
Packs/ctf01/Integrations/CortexXDRIRCTF
   CortexXDRIRCTF.py4644640%1–7, 10, 12–14, 16–18, 20, 37, 44, 52–57, 60–68, 71–72, 75–76, 79–80, 83–88, 91–98, 101, 109–121, 123–125, 128, 130, 134–138, 140, 143, 145, 153, 159, 163, 166–171, 173, 179–182, 184, 186, 208–209, 211, 216–217, 219–220, 224–225, 230–232, 238–239, 245–246, 251, 256–260, 263–264, 270–271, 277–278, 284–285, 291–292, 298–299, 301, 307, 309, 311, 319, 324, 331, 333, 335–340, 342, 344–345, 351, 358, 360–361, 367, 375, 377–378, 384, 387–389, 392, 400–402, 404, 408–410, 412, 415–416, 418–423, 426–427, 429, 432, 441–443, 445–447, 449–450, 453, 455–456, 545–552, 554, 556–557, 560, 562–563, 565, 567–568, 570, 572, 577, 580, 582–589, 591–595, 597, 599–607, 614, 616, 629, 632–636, 640–641, 646–648, 650, 652, 654, 656, 669, 671, 678, 681–685, 687, 690, 692, 695, 697, 704, 707–709, 711–713, 715–716, 718–720, 722–723, 725, 727–728, 730, 733–737, 739, 742, 746–751, 754–758, 767–768, 770–773, 775, 778–781, 783–784, 786, 789–791, 793, 795–797, 799, 801–804, 806, 809–811, 813–814, 817, 819, 823–824, 826–827, 829, 832, 835–836, 840, 843, 845–848, 850, 852, 858, 863, 868–869, 872–873, 875–877, 880, 883, 888, 894, 900, 1154, 1157, 1173–1174, 1178–1179, 1181–1182, 1184–1186, 1188–1189, 1194–1195, 1200, 1206–1208, 1210, 1212–1213, 1217–1218, 1220, 1222–1223, 1225–1227, 1233–1234, 1237–1238, 1240–1241, 1243–1245, 1247–1249, 1252, 1254–1255, 1257, 1259, 1261, 1264–1265, 1267–1268, 1273, 1278, 1281, 1283, 1291–1295, 1298, 1306, 1310, 2223–2226, 2228–2229, 2231, 2233, 2245, 2254–2256, 2258–2263, 2265, 2269, 2271, 2274, 2283, 2286–2291, 2293–2294, 2300, 2304, 2306, 2308, 2312
TOTAL269881469% 

Tests Skipped Failures Errors Time
147 0 💤 0 ❌ 0 🔥 2.347s ⏱️

@DeanArbel DeanArbel merged commit a56a1bf into master Apr 14, 2024
18 of 20 checks passed
@DeanArbel DeanArbel deleted the XSUP-35889/fixing-xdr-mirrored-close-reason-resolution branch April 14, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants