Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exabeam: added default false for isFetch #33915

Merged
merged 3 commits into from Apr 11, 2024
Merged

Exabeam: added default false for isFetch #33915

merged 3 commits into from Apr 11, 2024

Conversation

moishce
Copy link
Contributor

@moishce moishce commented Apr 11, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

When you define an instance in a version that does not have a fetch incidents command, and after that, you upgrade to a new version that has fetch incidents, the isFetch parameter is not present.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Apr 11, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/Exabeam/Integrations/Exabeam
   Exabeam.py80737154%36, 41–43, 49, 58–61, 94, 96, 98, 105, 117, 122–123, 133–134, 162, 167–168, 184, 220, 224–225, 237, 241–242, 254–256, 281, 289, 294–295, 297–298, 312, 320, 322–323, 334, 339, 341–342, 353, 355–356, 367–368, 370–371, 401, 403–404, 406, 410, 412–413, 415, 430, 434–435, 437–439, 455, 462, 464–465, 479, 483–484, 486–488, 525, 527, 541–543, 547, 549, 551–553, 568, 570–571, 575, 577, 579–580, 582, 623, 625–626, 628, 630–632, 634, 636–637, 640, 642, 653, 655–656, 659–660, 662, 748–749, 753–756, 802–806, 835, 1062, 1064, 1066–1071, 1073, 1075, 1087–1088, 1096, 1098–1103, 1106–1109, 1111, 1113, 1115, 1117, 1235–1236, 1247–1256, 1258–1259, 1261–1262, 1264–1267, 1269–1272, 1274–1275, 1277, 1287–1288, 1291–1296, 1298–1299, 1301–1302, 1313–1319, 1321–1324, 1326–1327, 1337, 1343, 1345, 1416–1417, 1419, 1434, 1476–1478, 1480, 1482–1483, 1486, 1497–1499, 1501–1504, 1506–1507, 1510, 1521–1523, 1525–1530, 1533, 1544–1551, 1553, 1562–1563, 1565, 1567, 1579–1582, 1584, 1586–1591, 1593, 1596, 1598, 1609–1610, 1612–1615, 1617–1618, 1620, 1622, 1633, 1635–1641, 1643, 1654, 1656–1659, 1661–1663, 1665, 1694–1698, 1700–1701, 1703–1706, 1708, 1710, 1712, 1723–1727, 1729–1734, 1736, 1739, 1750–1752, 1754–1755, 1757, 1759, 1770–1772, 1774–1775, 1777, 1784, 1788, 1799–1802, 1804, 1806–1807, 1818–1821, 1823, 1825–1826, 1859–1863, 1865, 1867–1868, 1879, 1881, 1883–1884, 1899, 1904, 1907, 1913, 1993, 2028, 2055, 2060–2062, 2078
TOTAL80737154% 

Tests Skipped Failures Errors Time
36 0 💤 0 ❌ 0 🔥 2.269s ⏱️


##### Exabeam

- Fixed an issue where this integration caused "TypeError".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed an issue where this integration caused "TypeError".
- Fixed an issue where this integration caused a "ValueError" exception.

@moishce moishce merged commit fcbd502 into master Apr 11, 2024
17 checks passed
@moishce moishce deleted the exabeam-is-fetch branch April 11, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants