Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XSUP-36157 - A fix to MapRangeValues script #34013

Merged
merged 7 commits into from Apr 18, 2024
Merged

XSUP-36157 - A fix to MapRangeValues script #34013

merged 7 commits into from Apr 18, 2024

Conversation

RotemAmit
Copy link
Contributor

@RotemAmit RotemAmit commented Apr 16, 2024 •
edited

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

  • Fixed an issue where the value of the numbers were automatically converted to float instead of int.
  • Updated the sep argument to not required.

Must have

  • Tests
  • Documentation

image

@RotemAmit RotemAmit requested a review from MLainer1 April 16, 2024 13:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/FiltersAndTransformers/Scripts/MapRangeValues
   MapRangeValues.py47295%38–39
TOTAL47295% 

Tests Skipped Failures Errors Time
22 0 💤 0 ❌ 0 🔥 1.270s ⏱️

MLainer1
MLainer1 reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@MLainer1 MLainer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)
Please add a picture of the green test playbook to the PR

@RotemAmit RotemAmit merged commit 632d262 into master Apr 18, 2024
20 checks passed
@RotemAmit RotemAmit deleted the xsup-36157/map_range_values branch April 18, 2024 07:51
barryyosi-panw pushed a commit that referenced this pull request Apr 24, 2024
@RotemAmit @eyalpalo @barryyosi-panw
XSUP-36157 - A fix to MapRangeValues script (#34013)
00254f8 
* the fix

* added a test playbook

* docker image update and test playbook connection

* Update Packs/FiltersAndTransformers/ReleaseNotes/1_2_68.md

Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com>

---------

Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MLainer1 MLainer1 MLainer1 left review comments

@eyalpalo eyalpalo eyalpalo approved these changes

@sapirshuker sapirshuker Awaiting requested review from sapirshuker sapirshuker is a code owner

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
3 participants
@RotemAmit @eyalpalo @MLainer1