Qualysv2: added start date to the test-module #34026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
||||||||||||||||||||||||||||||
| @@ -3048,7 +3048,7 @@ def test_module(client: Client, params: dict[str, Any], first_fetch_time: str) - | |||
| Returns: | |||
| str: 'ok' if test passed, anything else will raise an exception and will fail the test. | |||
| """ | |||
| build_args_dict(None, COMMANDS_ARGS_DATA["test-module"], False) | |||
| build_args_dict({'launched_after_datetime': 'one day'}, COMMANDS_ARGS_DATA["test-module"], False) | |||
There was a problem hiding this comment.
why not use the first_fetch?
ShahafBenYakir
approved these changes
Apr 21, 2024
barryyosi-panw
pushed a commit
that referenced
this pull request
Apr 24, 2024
* added start date to the test-module * added rn * improvements * update docker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
added start date to the test-module to prevent timeout.
Must have