Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseEmailFiles: Fixed an issue where same eml files are not recognized #34081

Merged
merged 2 commits into from Apr 21, 2024

Conversation

moishce
Copy link
Contributor

@moishce moishce commented Apr 21, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@moishce moishce requested a review from tkatzir April 21, 2024 11:12
Copy link

github-actions bot commented Apr 21, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CommonScripts/Scripts/ParseEmailFilesV2
   ParseEmailFilesV2.py101892%24, 31, 90, 106–107, 109–110, 134
TOTAL101892% 

Tests Skipped Failures Errors Time
17 0 💤 0 ❌ 0 🔥 2.809s ⏱️

Copy link
Contributor

@tkatzir tkatzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Approved.

@tkatzir
Copy link
Contributor

tkatzir commented Apr 21, 2024

Force merged due to unrelated build issues.

@tkatzir tkatzir merged commit 647da91 into master Apr 21, 2024
21 of 23 checks passed
@tkatzir tkatzir deleted the parse-email-files-chack-file-type branch April 21, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants