Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreIR fix get starred='false' incidents #34307

Merged
merged 15 commits into from
May 12, 2024
Merged

Conversation

DinaMeylakh
Copy link
Contributor

@DinaMeylakh DinaMeylakh commented May 9, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Running get_incidents with starred=false from CoreIRApiModule integration will now correctly return only non-starred incidents.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented May 9, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ApiModules/Scripts/CoreIRApiModule
   CoreIRApiModule.py161525384%184, 187, 192, 206, 237, 244, 258, 265, 272, 294, 340, 345, 388, 403, 414, 426, 486–487, 493–498, 523, 529, 535, 547, 557, 563, 582, 594, 600, 606, 618, 628, 634, 670, 705, 734, 750, 752, 860, 890, 893, 903, 972, 978, 998, 1004, 1006, 1033, 1049, 1235, 1259, 1265, 1278, 1280–1281, 1283, 1289–1290, 1296–1297, 1303, 1310–1311, 1344, 1346, 1392, 1399, 1406, 1412, 1418, 1425, 1432, 1442, 1472, 1548–1551, 1553–1559, 1564, 1569–1572, 1574–1575, 1577–1578, 1580–1584, 1586–1587, 1589, 1593, 1600–1601, 1616–1617, 1633, 1638, 1646, 1694–1696, 1700, 1703, 1727, 1812, 1818, 1822, 1826, 1831, 1837, 1849–1850, 1856, 1861, 1867, 1870–1872, 1904, 1907–1910, 2024, 2097, 2103, 2107, 2111, 2114, 2528, 2539, 2542–2544, 2548–2551, 2555–2556, 2562, 2564–2568, 2572, 2578, 2580–2581, 2583, 2587–2590, 2592, 2599, 2601–2602, 2605–2609, 2612, 2614, 2616, 2618–2621, 2625–2626, 2628–2633, 2635, 2666, 2841–2844, 2848–2849, 2860, 2960, 2989, 2991, 2993, 3233–3234, 3326–3328, 3336, 3357, 3471–3474, 3560, 3568, 3572–3573, 3631–3633, 3639, 3678, 3692, 3699, 3706, 3748, 3755, 3762, 3769, 3776, 3980, 4016–4019, 4021–4023, 4126, 4160, 4166, 4173, 4175, 4182, 4184, 4202, 4225
Packs/Core/Integrations/CortexCoreIR
   CortexCoreIR.py551278%36–39, 41, 44, 47, 54, 59, 62, 64, 108
Packs/CortexXDR/Integrations/CortexXDRIR
   CortexXDRIR.py5698185%59, 67, 71–73, 148–152, 154, 157, 160, 164, 232–236, 238, 245–248, 259, 262, 265, 271, 274, 300, 305, 313, 315, 318–322, 324, 393, 407–412, 444, 480, 509, 519, 578, 581, 607, 614, 616, 693–694, 696, 749, 930–932, 935, 938, 943, 997–998, 1049, 1058, 1060–1062, 1065, 1068–1069, 1106–1109, 1141, 1158
Packs/ctf01/Integrations/CortexXDRIRCTF
   CortexXDRIRCTF.py4644640%1–7, 10, 12–14, 16–18, 20, 37, 44, 52–57, 60–68, 71–72, 75–76, 79–80, 83–88, 91–98, 101, 109–121, 123–125, 128, 130, 134–138, 140, 143, 145, 153, 159, 163, 166–171, 173, 179–182, 184, 186, 208–209, 211, 216–217, 219–220, 224–225, 230–232, 238–239, 245–246, 251, 256–260, 263–264, 270–271, 277–278, 284–285, 291–292, 298–299, 301, 307, 309, 311, 319, 324, 331, 333, 335–340, 342, 344–345, 351, 358, 360–361, 367, 375, 377–378, 384, 387–389, 392, 400–402, 404, 408–410, 412, 415–416, 418–423, 426–427, 429, 432, 441–443, 445–447, 449–450, 453, 455–456, 545–552, 554, 556–557, 560, 562–563, 565, 567–568, 570, 572, 577, 580, 582–589, 591–595, 597, 599–607, 614, 616, 629, 632–636, 640–641, 646–648, 650, 652, 654, 656, 669, 671, 678, 681–685, 687, 690, 692, 695, 697, 704, 707–709, 711–713, 715–716, 718–720, 722–723, 725, 727–728, 730, 733–737, 739, 742, 746–751, 754–758, 767–768, 770–773, 775, 778–781, 783–784, 786, 789–791, 793, 795–797, 799, 801–804, 806, 809–811, 813–814, 817, 819, 823–824, 826–827, 829, 832, 835–836, 840, 843, 845–848, 850, 852, 858, 863, 868–869, 872–873, 875–877, 880, 883, 888, 894, 900, 1154, 1157, 1173–1174, 1178–1179, 1181–1182, 1184–1186, 1188–1189, 1194–1195, 1200, 1206–1208, 1210, 1212–1213, 1217–1218, 1220, 1222–1223, 1225–1227, 1233–1234, 1237–1238, 1240–1241, 1243–1245, 1247–1249, 1252, 1254–1255, 1257, 1259, 1261, 1264–1265, 1267–1268, 1273, 1278, 1281, 1283, 1291–1295, 1298, 1306, 1310, 2223–2226, 2228–2229, 2231, 2233, 2245, 2254–2256, 2258–2263, 2265, 2269, 2271, 2274, 2283, 2286–2291, 2293–2294, 2300, 2304, 2306, 2308, 2312
TOTAL270381070% 

Tests Skipped Failures Errors Time
160 0 💤 0 ❌ 0 🔥 2.482s ⏱️

@DinaMeylakh DinaMeylakh marked this pull request as ready for review May 12, 2024 11:37
@DinaMeylakh
Copy link
Contributor Author

@ShahafBenYakir The failures are non-related and occurred also during nightly: https://jira-dc.paloaltonetworks.com/browse/CIAC-9932

@ShahafBenYakir ShahafBenYakir merged commit bf50665 into master May 12, 2024
21 of 22 checks passed
@ShahafBenYakir ShahafBenYakir deleted the core_ir_make_starred_work branch May 12, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants