Digital guardian Bug #34920
Merged
Digital guardian Bug #34920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your contributed DigitalGuardian pack has been modified on files:Packs/DigitalGuardian/ReleaseNotes/1_1_5.md |
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||
| @@ -180,8 +180,8 @@ def check_componentlist_entry(): | |||
|
|
|||
| if 200 <= r.status_code <= 299: | |||
| for jText in json_text: | |||
| if str(jText['content_value']).lower() == componentlist_entry.lower(): | |||
| componentlist = jText['content_value'] | |||
| if str(jText.get('content_value')).lower() == componentlist_entry.lower(): | |||
There was a problem hiding this comment.
perhaps return a default empty string jText.get('content_value', '')
because we are doing lower on that and it will throw exception if returns None
| @@ -125,8 +125,8 @@ def get_watchlist_entry_id(watchlist_name: str, watchlist_entry: str) -> str: | |||
| if r.status_code != requests.codes.ok: | |||
| return_error('Unable to retrieve watchlist entries') | |||
| for jText in json_text: | |||
| if str(jText['value_name']).lower() == watchlist_entry.lower(): | |||
| watchlist_entry_id = jText['value_id'] | |||
| if str(jText.get('value_name')).lower() == watchlist_entry.lower(): | |||
There was a problem hiding this comment.
same here:
jText.get('content_value', '')
|
|
||
| DEBUG("cef: " + json.dumps(cef)) | ||
| for artifact_key, artifact_tuple in specific_alert_mapping.get(CATEGORY).items(): # type: ignore | ||
| if alert.get(artifact_tuple[0]): | ||
| cef[artifact_key] = alert[artifact_tuple[0]] | ||
| cef_types[artifact_key] = artifact_tuple[1] | ||
| if cef: | ||
| comm = alert['dg_alarm_name'].find(',') | ||
| comm = alert.get('dg_alarm_name').find(',') |
There was a problem hiding this comment.
same here:
alert.get('dg_alarm_name', '')
| result = dict(zip(outcome, event)) | ||
| event_list.append(result) | ||
| event_list.sort(key=lambda item: (item["inc_mtime"], item["dg_guid"])) | ||
| event_list.sort(key=lambda item: (item.get("inc_mtime"), item.get("dg_guid"))) |
There was a problem hiding this comment.
Add a unit test that tests this method were item does not have inc_mtime and dg_guid and see that it is working.
|
@thefrieddan1 Doc review completed. |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
thefrieddan1
approved these changes
Jun 19, 2024
amshamah419
pushed a commit
that referenced
this pull request
Jun 20, 2024
* fixed parsing events from api * fix * added rn * fix * fix * fixes * fixes * added rn * updated do * pre-commit edits * Update Packs/DigitalGuardian/ReleaseNotes/1_1_5.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/DigitalGuardian/ReleaseNotes/1_1_5.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fixes * made a change for the unit test * edit * added fixes for unittests * fixed do --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-38319
Description
fixed an issue where fetch events failed when some fields from the api were empty
Must have