[CSP] Revert PR 34921

[mmhw]

Status

• In Progress
• Ready
• In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

In PR #34921 I added to the generic_http_request function that if there is a file, then f.read() will be done to it, but actually this caused the buffer to be at the end of the file and basically it will always upload an empty file.

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
Packs/Base/Scripts/CommonServerPython
CommonServerPython.py	4448	672	84%	169–172, 183, 185, 421, 463, 559, 585–589, 614, 629, 769–770, 779, 820–821, 839, 869–873, 877–879, 921, 1008–1016, 1060–1065, 1099–1101, 1231–1235, 1238–1239, 1241–1243, 1257–1259, 1261, 1327, 1340, 1353, 1361–1363, 1365, 1378, 1386, 1473–1474, 1529, 1551–1552, 1555, 1561, 1563, 1565, 1659, 1704, 1778–1779, 1783–1784, 1823–1824, 1838–1843, 1845, 1913, 1996, 1998, 2018, 2048, 2052, 2094, 2273, 2297, 2336–2337, 2417–2418, 2420, 2433–2440, 2442, 2519–2521, 2535, 2548, 2579, 2585–2589, 2591–2593, 2595, 2599–2600, 2602, 2615–2621, 2625, 2629–2631, 2637–2638, 2650, 2678, 2681, 2686, 2706, 2712, 2714, 2716, 2736, 2739, 2751, 2797–2805, 2807, 2866, 2888, 2908, 2966, 2978–2979, 3091, 3093, 3268, 3278, 3284, 3293, 3299, 3313, 3369, 3384, 3386, 3417–3422, 3425, 3476–3477, 3480, 3646–3647, 3650, 3757, 3760, 3985, 3988, 3991, 3994, 3999, 4008, 4034, 4040, 4043, 4052, 4054, 4170–4171, 4195, 4197, 4216, 4219, 4222, 4290, 4311, 4313, 4449, 4467, 4479, 4515, 4517, 4691–4692, 4770, 4772, 4797, 4812–4828, 4831, 4835–4836, 4838–4839, 4841–4842, 4844–4845, 4847–4848, 4850–4851, 4853–4854, 4856–4857, 4859–4860, 4862–4863, 4865–4866, 4868–4869, 4871–4872, 4874, 4876–4877, 4879–4882, 4884–4886, 4888, 4890, 4894, 4965, 4997, 5003, 5005, 5043, 5048–5049, 5054, 5058–5059, 5061, 5143, 5149, 5241, 5262, 5265–5270, 5278–5284, 5286–5287, 5332, 5345, 5440–5443, 5448, 5451, 5454, 5488, 5491, 5535, 5537, 5539, 5634, 5685, 5767, 5779, 5797, 5837–5838, 5842, 5844, 5878, 5882, 5884, 5886, 5888, 5934, 5938, 6037–6040, 6042, 6055, 6074, 6084, 6090, 6099–6101, 6104–6107, 6122, 6164, 6193, 6196, 6245–6248, 6251–6255, 6259, 6267, 6273, 6301, 6330, 6336–6337, 6388, 6408–6409, 6411, 6451–6452, 6459, 6464, 6470, 6483–6484, 6486, 6757–6759, 6778, 6791, 6803, 6831, 6991, 7006, 7071, 7101, 7139–7140, 7152, 7167–7168, 7170–7171, 7173–7174, 7176–7177, 7179–7182, 7184, 7186–7187, 7189, 7268–7269, 7281, 7325–7328, 7330, 7337–7338, 7498, 7553, 7588, 7608, 7610, 7711, 7871–7874, 7876–7878, 7937, 7956–7957, 7969, 7985, 8006–8007, 8009, 8026, 8113, 8127, 8130–8133, 8136, 8139, 8161–8164, 8261, 8280–8281, 8409, 8494, 8498–8499, 8513, 8516, 8529–8531, 8534, 8606, 8776–8777, 8857–8858, 8902–8903, 8905, 8908, 8919, 8925–8928, 8930, 8932, 8934–8935, 9051, 9176, 9190, 9193, 9397, 9406, 9472–9473, 9477, 9538–9541, 9543, 9565, 9577, 9673, 9709–9710, 9723, 9736–9741, 9757–9758, 9766–9767, 9780, 9788–9789, 9806–9807, 9821, 9831, 9847, 9858, 9866–9868, 9870, 9896, 9911, 9922, 9940–9941, 9944, 9962, 9965, 9980, 9994, 10000, 10015, 10032, 10044–10052, 10055–10056, 10058, 10073–10075, 10086, 10089, 10177, 10203, 10210, 10254, 10280–10281, 10324, 10326–10328, 10330, 10401, 10410, 10531, 10595, 10599–10600, 10691–10696, 10791–10794, 10884–10886, 10912, 10945, 10995–10996, 11001–11002, 11019, 11105–11107, 11126, 11334, 11450, 11474, 11497, 11522, 11529–11535, 11537, 11539, 11682, 11731–11732, 11734–11741, 11746–11748, 11750, 11752, 11853–11854, 11872, 11905–11906, 11910, 11950, 11953, 11955–11956, 11958, 11960, 11962, 11964–11967, 11969, 11971–11972, 11976–11978, 12011
TOTAL	4448	672	84%

Tests	Skipped	Failures	Errors	Time
5047	87 💤	0 ❌	0 🔥	3m 35s ⏱️